Skip to content

build(windows): ensure versions are compliant with wix and msi#151

Merged
ReenigneArcher merged 1 commit into
masterfrom
build/windows/ensure-versions-are-compliant-with-cargo-wix-and-msi
Jun 24, 2026
Merged

build(windows): ensure versions are compliant with wix and msi#151
ReenigneArcher merged 1 commit into
masterfrom
build/windows/ensure-versions-are-compliant-with-cargo-wix-and-msi

Conversation

@ReenigneArcher

Copy link
Copy Markdown
Member

Description

Fixes version issue on Windows msi installer packages, by using wix directly instead of relying on cargo-wix. cargo-wix will automatically fail if major and minor version numbers are > 255, while wix itself will just emit warnings for this.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@ReenigneArcher ReenigneArcher force-pushed the build/windows/ensure-versions-are-compliant-with-cargo-wix-and-msi branch from aec47e8 to 1f9539d Compare June 24, 2026 17:28
@ReenigneArcher ReenigneArcher changed the title build(windows): ensure versions are compliant with cargo-wix and msi build(windows): ensure versions are compliant with wix and msi Jun 24, 2026
@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 44.89796% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.93%. Comparing base (887d670) to head (1f9539d).

Files with missing lines Patch % Lines
xtask/src/main.rs 44.89% 27 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #151      +/-   ##
==========================================
- Coverage   51.96%   51.93%   -0.03%     
==========================================
  Files          40       40              
  Lines       13142    13191      +49     
==========================================
+ Hits         6829     6851      +22     
- Misses       6313     6340      +27     
Flag Coverage Δ
aarch64-apple-darwin 51.02% <44.89%> (-0.03%) ⬇️
aarch64-unknown-linux-gnu ?
aarch64-unknown-linux-musl 51.56% <44.89%> (-0.03%) ⬇️
x86_64-apple-darwin 51.02% <44.89%> (-0.03%) ⬇️
x86_64-pc-windows-msvc 51.90% <44.89%> (-0.03%) ⬇️
x86_64-unknown-linux-gnu 51.01% <44.89%> (-0.03%) ⬇️
x86_64-unknown-linux-musl 51.56% <44.89%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
xtask/src/main.rs 8.39% <44.89%> (+8.39%) ⬆️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 887d670...1f9539d. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ReenigneArcher ReenigneArcher merged commit 5dd0973 into master Jun 24, 2026
45 of 46 checks passed
@ReenigneArcher ReenigneArcher deleted the build/windows/ensure-versions-are-compliant-with-cargo-wix-and-msi branch June 24, 2026 18:36
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

build: version not accepted by cargo-wix

1 participant