Skip to content

feat(video): add support for legacy MPEG-2 and H.263+ encoders#5194

Draft
ReenigneArcher wants to merge 1 commit into
masterfrom
feat/legacy-encoders
Draft

feat(video): add support for legacy MPEG-2 and H.263+ encoders#5194
ReenigneArcher wants to merge 1 commit into
masterfrom
feat/legacy-encoders

Conversation

@ReenigneArcher

@ReenigneArcher ReenigneArcher commented May 25, 2026

Copy link
Copy Markdown
Member

Description

Adds MPEG-2 and H.263+ encoder support, required for LizardByte/Moonlight-XboxOG#194

TODO:

  • new release of build-deps and update submodule/flatpak modules here
  • create and wait for merge of PR to moonlight-common-c

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@codecov

codecov Bot commented May 25, 2026

Copy link
Copy Markdown

Bundle Report

Changes will increase total bundle size by 2.07kB (0.09%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sunshine-esm 799.62kB 2.07kB (0.26%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sunshine-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/createLucideIcon-*.js 994 bytes 358.31kB 0.28%
assets/config-*.js 1.07kB 70.55kB 1.54%

Files in assets/createLucideIcon-*.js:

  • ./src_assets/common/assets/web/public/assets/locale/en.json → Total Size: 41.17kB

Files in assets/config-*.js:

  • ./src_assets/common/assets/web/config.html → Total Size: 0 bytes

  • ./src_assets/common/assets/web/configs/tabs/Advanced.vue → Total Size: 11.72kB

@codecov

codecov Bot commented May 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 41.28440% with 128 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.05%. Comparing base (f81a495) to head (0b8181d).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/video.cpp 44.50% 70 Missing and 36 partials ⚠️
src/rtsp.cpp 0.00% 8 Missing and 6 partials ⚠️
src/nvhttp.cpp 0.00% 4 Missing ⚠️
src/config.cpp 0.00% 0 Missing and 2 partials ⚠️
src/video.h 71.42% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5194      +/-   ##
==========================================
+ Coverage   17.85%   18.05%   +0.19%     
==========================================
  Files         111      111              
  Lines       24605    24793     +188     
  Branches    10894    10973      +79     
==========================================
+ Hits         4393     4476      +83     
- Misses      14945    16698    +1753     
+ Partials     5267     3619    -1648     
Flag Coverage Δ
Archlinux 11.33% <26.14%> (+0.14%) ⬆️
FreeBSD-amd64 13.51% <30.97%> (+0.27%) ⬆️
Homebrew-ubuntu-24.04 13.36% <27.45%> (+0.14%) ⬆️
Linux-AppImage 12.25% <26.79%> (+0.14%) ⬆️
Windows-AMD64 15.08% <28.10%> (+0.16%) ⬆️
Windows-ARM64 13.40% <24.26%> (+0.20%) ⬆️
macOS-arm64 19.36% <27.81%> (+0.23%) ⬆️
macOS-x86_64 18.86% <27.81%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/config.h 0.00% <ø> (ø)
src/config.cpp 3.05% <0.00%> (-0.01%) ⬇️
src/video.h 61.40% <71.42%> (+1.40%) ⬆️
src/nvhttp.cpp 18.80% <0.00%> (-0.13%) ⬇️
src/rtsp.cpp 1.99% <0.00%> (-0.04%) ⬇️
src/video.cpp 33.88% <44.50%> (+1.52%) ⬆️

... and 56 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f81a495...0b8181d. Read the comment docs.

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
14 New issues
14 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant