Skip to content

feat(linux/cuda-gl): Allow YUV4:2:0 HDR and YUV4:4:4 HDR on nvidia cards#5315

Merged
ReenigneArcher merged 2 commits into
LizardByte:masterfrom
Sheynar:linux/cuda-gl-hdr
Jun 24, 2026
Merged

feat(linux/cuda-gl): Allow YUV4:2:0 HDR and YUV4:4:4 HDR on nvidia cards#5315
ReenigneArcher merged 2 commits into
LizardByte:masterfrom
Sheynar:linux/cuda-gl-hdr

Conversation

@Sheynar

@Sheynar Sheynar commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Description

Allow HDR implementation on Nvidia cards linux, cuda-gl pipeline (wayland).

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@Sheynar Sheynar changed the title feat(linux/cuda-gl) Add YUV4:2:0 HDR and YUV4:4:4 HDR on nvidia cards feat(linux/cuda-gl): Add YUV4:2:0 HDR and YUV4:4:4 HDR on nvidia cards Jun 22, 2026
@Sheynar Sheynar marked this pull request as draft June 22, 2026 06:04
@Sheynar

Sheynar commented Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

First, returned to how it worked before #4965 plus added yuv444 pipeline run.

@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Bundle Report

Bundle size has no change ✅

@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.01%. Comparing base (338afe6) to head (bb94706).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/platform/linux/cuda.cpp 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5315      +/-   ##
==========================================
- Coverage   18.01%   18.01%   -0.01%     
==========================================
  Files         111      111              
  Lines       24613    24615       +2     
  Branches    10897    10899       +2     
==========================================
  Hits         4435     4435              
+ Misses      18264    14950    -3314     
- Partials     1914     5230    +3316     
Flag Coverage Δ
Archlinux 11.50% <0.00%> (-0.01%) ⬇️
FreeBSD-amd64 13.31% <ø> (-0.01%) ⬇️
Homebrew-ubuntu-24.04 13.53% <ø> (ø)
Linux-AppImage 12.41% <0.00%> (-0.01%) ⬇️
Windows-AMD64 15.27% <ø> (ø)
Windows-ARM64 13.30% <ø> (ø)
macOS-arm64 19.27% <ø> (ø)
macOS-x86_64 18.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/platform/linux/cuda.cpp 1.67% <0.00%> (-0.01%) ⬇️

... and 68 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 338afe6...bb94706. Read the comment docs.

@ReenigneArcher

Copy link
Copy Markdown
Member

@Sheynar looks like this has confirmation it fixes the linked issue. Let me know whenever you mark it ready for review. Thanks!

@Sheynar Sheynar changed the title feat(linux/cuda-gl): Add YUV4:2:0 HDR and YUV4:4:4 HDR on nvidia cards feat(linux/cuda-gl): Allow YUV4:2:0 HDR and YUV4:4:4 HDR on nvidia cards Jun 24, 2026
@Sheynar Sheynar force-pushed the linux/cuda-gl-hdr branch from 689573e to 3b8da09 Compare June 24, 2026 12:56
@Sheynar Sheynar marked this pull request as ready for review June 24, 2026 16:06
@ReenigneArcher ReenigneArcher merged commit e4740f0 into LizardByte:master Jun 24, 2026
70 of 71 checks passed
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Linux] [Beta] NVENC/KMS HDR regression in 617.152807

2 participants