Skip to content

Conversation

RandallFlagg
Copy link
Contributor

@RandallFlagg RandallFlagg commented Jun 18, 2025

@Hirogen can you please look at the change I did in LogWindowPublic?
I am a bit confused as why everything is working by me. Am I missing a scenario where that change is not good? This created a huge resource and performance impact on my system.

@Hirogen
Copy link
Collaborator

Hirogen commented Jun 19, 2025

@Hirogen can you please look at the change I did in LogWindowPublic? I am a bit confused as why everything is working by me. Am I missing a scenario where that change is not good? This created a huge resource and performance impact on my system.

Seems to work normal on my system, 6 files with 500mb open and uses about 5gig on memory and a little bit of processor time

image

But it's not possible to close a file while the filter is running, it will throw a cross thread exception, this is probably because the StatuslineEventWorker has been started by a Task and is now called again by another thread.

I also get
image

but I hope this is due to the missing catch()

Filters take forever, for just a few lines to find.
image

_disposeLock.AcquireReaderLock(Timeout.Infinite);
try
{
ct.ThrowIfCancellationRequested();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's just a draft, but the try, finally is imo worse then the old design

Also I'm confused why so many ct.ThrowIfCancellationRequested();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants