Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typos #2739

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/hebao_v1/contracts/modules/base/BaseModule.sol
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ abstract contract BaseModule is Module
feeCollector = _controller.feeCollector();
}

/// @dev This method will cause an re-entry to the same module contract.
/// @dev This method will cause a re-entry to the same module contract.
function activate()
external
override
Expand All @@ -85,7 +85,7 @@ abstract contract BaseModule is Module
emit Activated(wallet);
}

/// @dev This method will cause an re-entry to the same module contract.
/// @dev This method will cause a re-entry to the same module contract.
function deactivate()
external
override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ abstract contract ForwarderModule is SecurityModule
2300; // 2*SLOAD+1*CALL = 2*800+1*700=2300

if (metaTx.gasToken == address(0)) {
gasUsed -= 15000; // diff between an regular ERC20 transfer and an ETH send
gasUsed -= 15000; // diff between a regular ERC20 transfer and an ETH send
}

uint gasToReimburse = gasUsed <= metaTx.gasLimit ? gasUsed : metaTx.gasLimit;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ contract BaseModule is ReentrancyGuard, Module
Wallet(wallet).addModule(module);
}

/// @dev This method will cause an re-entry to the same module contract.
/// @dev This method will cause a re-entry to the same module contract.
function activate()
external
override
Expand All @@ -83,7 +83,7 @@ contract BaseModule is ReentrancyGuard, Module
emit Activated(wallet);
}

/// @dev This method will cause an re-entry to the same module contract.
/// @dev This method will cause a re-entry to the same module contract.
function deactivate()
external
override
Expand Down
2 changes: 1 addition & 1 deletion packages/hebao_v2/contracts/base/WalletFactory.sol
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ contract WalletFactory is WalletDeploymentLib, Ownable, AddressSet
addOperatorInternal(operator);
}

/// @dev Removes a operator.
/// @dev Removes an operator.
/// @param operator The operator to remove.
function removeOperator(address operator)
public
Expand Down
2 changes: 1 addition & 1 deletion packages/hebao_v3/contracts/base/WalletFactory.sol
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ contract WalletFactory is WalletDeploymentLib, Ownable, AddressSet {
addOperatorInternal(operator);
}

/// @dev Removes a operator.
/// @dev Removes an operator.
/// @param operator The operator to remove.
function removeOperator(address operator) public onlyOwner {
removeAddressFromSet(OPERATOR, operator);
Expand Down
2 changes: 1 addition & 1 deletion packages/hebao_v3/test/account-abstraction/gnosis.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@ describe('Gnosis Proxy', function () {
'0x1626ba7e'
)

// make an sig invalid
// make a sig invalid
const badWallet = ethers.Wallet.createRandom()
const badSig = await badWallet.signMessage(dataHash)
expect(
Expand Down
2 changes: 1 addition & 1 deletion packages/hebao_v3/test/inheritor.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ describe('inheritor test', () => {
).to.be.revertedWith('TOO_EARLY')
})

it('inherit with a owner in guardians group', async () => {
it('inherit with an owner in guardians group', async () => {
const test = async (removeGuardians: boolean): Promise<void> => {
const { smartWallet, create2, entrypoint, sendUserOp } =
await loadFixture(fixture)
Expand Down
6 changes: 3 additions & 3 deletions packages/loopring_v1/contracts/LoopringProtocol.sol
Original file line number Diff line number Diff line change
Expand Up @@ -53,13 +53,13 @@ contract LoopringProtocol {
uint _cutoff
);

/// @dev Cancel a order. cancel amount(amountS or amountB) can be specified
/// @dev Cancel an order. cancel amount(amountS or amountB) can be specified
/// in orderValues.
/// @param addresses owner, tokenS, tokenB, wallet, authAddr
/// @param orderValues amountS, amountB, validSince (second),
/// validUntil (second), lrcFee, and cancelAmount.
/// @param buyNoMoreThanAmountB -
/// This indicates when a order should be considered
/// This indicates when an order should be considered
/// as 'completely filled'.
/// @param marginSplitPercentage -
/// Percentage of margin split to share with miner.
Expand Down Expand Up @@ -130,7 +130,7 @@ contract LoopringProtocol {
/// AuthAddr, Wallet, RingR, RingS, RingV.
/// * Fee selections: Bits to indicate fee selections.
/// `1` represents margin split and `0` represents LRC as fee.
/// * BuyNoMoreThanAmountB: This indicates when a order should
/// * BuyNoMoreThanAmountB: This indicates when an order should
/// be considered as 'completely filled'.
function submitRing(
bytes data
Expand Down