Small Updates

* Updated so all the saved information is now run from Theme.lua
* Updated how we are grabbing certain information for quests/weeklys

Author: LoyalFTW

Modules/Delves.lua

@@ -187,12 +187,71 @@ MR:RegisterModule({
     labelColor  = "#c8956c",
     resetType   = "weekly",
     defaultOpen = false,
+    scanReturnsChanged = true,
 
     onScan = function(mod)
         local now = GetTime()
         local db  = MR.db.char.progress
         if not db[mod.key] then db[mod.key] = {} end
         local mdb = db[mod.key]
+        local beforeProgress = {}
+        for key, value in pairs(mdb) do
+            beforeProgress[key] = value
+        end
+        local beforeRows = {
+            bountiful_count = bountifulRow and {
+                countText = bountifulRow.countText,
+                countColor = bountifulRow.countColor and { unpack(bountifulRow.countColor) } or nil,
+                max = bountifulRow.max,
+                note = bountifulRow.note,
+            } or nil,
+            delve_bounty = bountyRow and {
+                countText = bountyRow.countText,
+                countColor = bountyRow.countColor and { unpack(bountyRow.countColor) } or nil,
+                max = bountyRow.max,
+                note = bountyRow.note,
+            } or nil,
+            gilded_stash = gildedStashRow and {
+                countText = gildedStashRow.countText,
+                countColor = gildedStashRow.countColor and { unpack(gildedStashRow.countColor) } or nil,
+                max = gildedStashRow.max,
+                note = gildedStashRow.note,
+            } or nil,
+        }
+        local function HasChanges()
+            for key, value in pairs(mdb) do
+                if beforeProgress[key] ~= value then
+                    return true
+                end
+            end
+            for key in pairs(beforeProgress) do
+                if mdb[key] ~= beforeProgress[key] then
+                    return true
+                end
+            end
+            for rowKey, beforeRow in pairs(beforeRows) do
+                local row = rowKey == "bountiful_count" and bountifulRow
+                    or rowKey == "delve_bounty" and bountyRow
+                    or gildedStashRow
+                if beforeRow and row then
+                    local beforeColor = beforeRow.countColor
+                    local afterColor = row.countColor
+                    local sameColor = (beforeColor == afterColor)
+                        or (type(beforeColor) == "table" and type(afterColor) == "table"
+                            and (beforeColor[1] or 0) == (afterColor[1] or 0)
+                            and (beforeColor[2] or 0) == (afterColor[2] or 0)
+                            and (beforeColor[3] or 0) == (afterColor[3] or 0)
+                            and (beforeColor[4] or 0) == (afterColor[4] or 0))
+                    if beforeRow.countText ~= row.countText
+                        or beforeRow.max ~= row.max
+                        or beforeRow.note ~= row.note
+                        or not sameColor then
+                        return true
+                    end
+                end
+            end
+            return false
+        end
 
         local exp = GetPlayerExpansion()
         if exp then
@@ -214,7 +273,7 @@ MR:RegisterModule({
             bountifulRow.countColor = nil
         end
 
-        if (now - lastScan) < SCAN_THROTTLE then return end
+        if (now - lastScan) < SCAN_THROTTLE then return HasChanges() end
         lastScan = now
 
         local buckets = MR.GetWeeklyRewardActivityBuckets and MR:GetWeeklyRewardActivityBuckets() or nil
@@ -261,6 +320,7 @@ MR:RegisterModule({
         end
 
         UpdateGildedStashProgress(mdb, gildedStashRow)
+        return HasChanges()
     end,
 
     rows = {

Modules/ProfessionKnowledge.lua

@@ -4,7 +4,11 @@ local MR = ns.MR
 local FONT_HEADERS = ns.FONT_HEADERS
 local FONT_ROWS = ns.FONT_ROWS
 local StyledFrame = ns.StyledFrame
-local RestoreFramePos = ns.RestoreFramePos
+local RestoreManagedFramePos = ns.RestoreManagedFramePos
+local SaveManagedFramePos = ns.SaveManagedFramePos
+local SyncManagedFramePos = ns.SyncManagedFramePos
+local AnimateManagedFrameHeight = ns.AnimateManagedFrameHeight
+local IsManagedHeaderBottom = ns.IsManagedHeaderBottom
 local LeftAccent = ns.LeftAccent
 local TopAccent = ns.TopAccent
 local TitleBar = ns.TitleBar
@@ -437,42 +441,20 @@ local function BuildGatheringLocationsFrame(isRetry)
     local width = db.gatheringWidth or DEFAULT_W
     local height = db.gatheringHeight or DEFAULT_H
     local minimized = db.gatheringMinimized or false
-    local headerBottom = MR.GetManagedHeaderPosition and MR:GetManagedHeaderPosition() == "bottom"
+    local headerBottom = IsManagedHeaderBottom()
     gatheringMinimized = minimized
 
     local function ApplyFrameHeight(frame, targetHeight)
-        if not (MR.IsManagedAnimatedMinimizeEnabled and MR:IsManagedAnimatedMinimizeEnabled()) then
-            frame:SetHeight(targetHeight)
-            return
-        end
-
-        local startHeight = frame:GetHeight() or targetHeight
-        local delta = targetHeight - startHeight
-        if math.abs(delta) < 1 then
-            frame:SetHeight(targetHeight)
-            return
-        end
-
-        frame._mrAnimTick = 0
-        frame:SetScript("OnUpdate", function(self, dt)
-            self._mrAnimTick = (self._mrAnimTick or 0) + (dt or 0)
-            local duration = math.min(0.18, math.max(0.06, math.abs(delta) / 1600))
-            local progress = math.min(self._mrAnimTick / duration, 1)
-            local eased = 1 - ((1 - progress) * (1 - progress) * (1 - progress))
-            self:SetHeight(startHeight + (delta * eased))
-            if progress >= 1 then
-                self:SetHeight(targetHeight)
-                self._mrAnimTick = nil
-                self:SetScript("OnUpdate", nil)
-            end
+        AnimateManagedFrameHeight(frame, targetHeight, function(self)
+            self:SetScript("OnUpdate", nil)
         end)
     end
 
     local frame = StyledFrame(UIParent, nil, "MEDIUM", 10)
     frame:SetSize(width, minimized and TITLE_H or height)
     frame:SetBackdropColor(0.03, 0.05, 0.08, 0.97 * alpha)
     frame:SetBackdropBorderColor(0.22, 0.18, 0.28, alpha)
-    RestoreFramePos(frame, "gatheringLocPos", 860, 0)
+    RestoreManagedFramePos(frame, "gatheringLocPos", 860, 0)
     frame.leftAccent = nil
     frame.topAccent = TopAccent(frame, 0.80, 0.53, 0.20)
     if frame.leftAccent then frame.leftAccent:SetAlpha(alpha) end
@@ -492,26 +474,7 @@ local function BuildGatheringLocationsFrame(isRetry)
     titleBar:SetScript("OnDragStart", function() if not db.gatheringLocked then frame:StartMoving() end end)
     titleBar:SetScript("OnDragStop", function()
         frame:StopMovingOrSizing()
-        if headerBottom then
-            local left = frame:GetLeft()
-            local bottom = frame:GetBottom()
-            if left and bottom and MR.db then
-                MR:SetWindowLayoutValue("gatheringLocPos", { point = "BOTTOMLEFT", relPoint = "BOTTOMLEFT", x = left, y = bottom })
-                return
-            end
-        else
-            local left = frame:GetLeft()
-            local top = frame:GetTop()
-            if left and top and MR.db then
-                MR:SetWindowLayoutValue("gatheringLocPos", { point = "TOPLEFT", relPoint = "BOTTOMLEFT", x = left, y = top })
-                return
-            end
-        end
-
-        local point, _, relPoint, x, y = frame:GetPoint()
-        if MR.db then
-            MR:SetWindowLayoutValue("gatheringLocPos", { point = point, relPoint = relPoint, x = x, y = y })
-        end
+        SaveManagedFramePos(frame, "gatheringLocPos", headerBottom and "bottom" or "top")
     end)
     if MR.ApplyPanelHeaderAutoHide then MR:ApplyPanelHeaderAutoHide(frame, titleBar) end
 
@@ -858,40 +821,13 @@ local function BuildGatheringLocationsFrame(isRetry)
         if minBtn.RefreshLabel then minBtn:RefreshLabel() end
 
         if gatheringMinimized then
-            if headerBottom then
-                local left = frame:GetLeft()
-                local bottom = frame:GetBottom()
-                if left and bottom then
-                    frame:ClearAllPoints()
-                    frame:SetPoint("BOTTOMLEFT", UIParent, "BOTTOMLEFT", left, bottom)
-                    if MR.db then
-                        MR:SetWindowLayoutValue("gatheringLocPos", { point = "BOTTOMLEFT", relPoint = "BOTTOMLEFT", x = left, y = bottom })
-                    end
-                end
-            else
-                local left = frame:GetLeft()
-                local top  = frame:GetTop()
-                if left and top then
-                    frame:ClearAllPoints()
-                    frame:SetPoint("TOPLEFT", UIParent, "BOTTOMLEFT", left, top)
-                    if MR.db then
-                        MR:SetWindowLayoutValue("gatheringLocPos", { point = "TOPLEFT", relPoint = "BOTTOMLEFT", x = left, y = top })
-                    end
-                end
-            end
+            SyncManagedFramePos(frame, "gatheringLocPos", headerBottom and "bottom" or "top")
             if frame._scroll then frame._scroll:Hide() end
             if frame._scrollTrack then frame._scrollTrack:Hide() end
             if frame._dragger then frame._dragger:Hide() end
             ApplyFrameHeight(frame, TITLE_H)
         else
-            if headerBottom then
-                local left = frame:GetLeft()
-                local bottom = frame:GetBottom()
-                if left and bottom then
-                    frame:ClearAllPoints()
-                    frame:SetPoint("BOTTOMLEFT", UIParent, "BOTTOMLEFT", left, bottom)
-                end
-            end
+            SyncManagedFramePos(frame, "gatheringLocPos", headerBottom and "bottom" or "top")
             if frame._scroll then frame._scroll:Show() end
             if frame._scrollTrack then frame._scrollTrack:Show() end
             if frame._dragger then frame._dragger:Show() end

Modules/PvP.lua

@@ -266,6 +266,7 @@ MR:RegisterModule({
     labelColor  = "#cc3333",
     resetType   = "weekly",
     defaultOpen = true,
+    scanReturnsChanged = true,
     onScan = function(mod)
         local progress = MR.db.char.progress
         if not progress[mod.key] then

Modules/Rares.lua

@@ -4,7 +4,11 @@ local MR = ns.MR
 local FONT_HEADERS = ns.FONT_HEADERS
 local FONT_ROWS = ns.FONT_ROWS
 local StyledFrame = ns.StyledFrame
-local RestoreFramePos = ns.RestoreFramePos
+local RestoreManagedFramePos = ns.RestoreManagedFramePos
+local SaveManagedFramePos = ns.SaveManagedFramePos
+local SyncManagedFramePos = ns.SyncManagedFramePos
+local AnimateManagedFrameHeight = ns.AnimateManagedFrameHeight
+local IsManagedHeaderBottom = ns.IsManagedHeaderBottom
 local LeftAccent = ns.LeftAccent
 local TopAccent = ns.TopAccent
 local TitleBar = ns.TitleBar
@@ -351,41 +355,19 @@ BuildRaresFrame = function()
     local singleZone = #visible == 1
     local cols       = (W >= 220) and COLS or 1
     local ROW_H      = GetRowH()
-    local headerBottom = MR.GetManagedHeaderPosition and MR:GetManagedHeaderPosition() == "bottom"
+    local headerBottom = IsManagedHeaderBottom()
 
     local function ApplyFrameHeight(frame, targetHeight)
-        if not (MR.IsManagedAnimatedMinimizeEnabled and MR:IsManagedAnimatedMinimizeEnabled()) then
-            frame:SetHeight(targetHeight)
-            return
-        end
-
-        local startHeight = frame:GetHeight() or targetHeight
-        local delta = targetHeight - startHeight
-        if math.abs(delta) < 1 then
-            frame:SetHeight(targetHeight)
-            return
-        end
-
-        frame._mrAnimTick = 0
-        frame:SetScript("OnUpdate", function(self, dt)
-            self._mrAnimTick = (self._mrAnimTick or 0) + (dt or 0)
-            local duration = math.min(0.18, math.max(0.06, math.abs(delta) / 1600))
-            local progress = math.min(self._mrAnimTick / duration, 1)
-            local eased = 1 - ((1 - progress) * (1 - progress) * (1 - progress))
-                self:SetHeight(startHeight + (delta * eased))
-            if progress >= 1 then
-                self:SetHeight(targetHeight)
-                self._mrAnimTick = nil
-                ApplyRaresFrameUpdater(self)
-            end
+        AnimateManagedFrameHeight(frame, targetHeight, function(self)
+            ApplyRaresFrameUpdater(self)
         end)
     end
 
     local f = StyledFrame(UIParent, nil, "MEDIUM", 10)
     f:SetSize(W, minimized and TITLE_H or H)
     f:SetBackdropColor(0.03, 0.02, 0.09, 0.97 * alpha)
     f:SetBackdropBorderColor(0.18, 0.10, 0.30, alpha)
-    RestoreFramePos(f, "raresPos", 580, 0)
+    RestoreManagedFramePos(f, "raresPos", 580, 0)
 
     f.leftAccent = nil
     f.topAccent  = TopAccent(f, 0.55, 0.28, 0.95)
@@ -407,16 +389,7 @@ BuildRaresFrame = function()
     titleBar:SetScript("OnDragStart", function() if not db.raresLocked then f:StartMoving() end end)
     titleBar:SetScript("OnDragStop", function()
         f:StopMovingOrSizing()
-        if headerBottom then
-            local left = f:GetLeft()
-            local bottom = f:GetBottom()
-            if left and bottom and MR.db then
-                MR:SetWindowLayoutValue("raresPos", { point = "BOTTOMLEFT", relPoint = "BOTTOMLEFT", x = left, y = bottom })
-                return
-            end
-        end
-        local pt, _, rp, x, y = f:GetPoint()
-        if MR.db then MR:SetWindowLayoutValue("raresPos", { point = pt, relPoint = rp, x = x, y = y }) end
+        SaveManagedFramePos(f, "raresPos", headerBottom and "bottom" or "top")
     end)
     if MR.ApplyPanelHeaderAutoHide then MR:ApplyPanelHeaderAutoHide(f, titleBar) end
 
@@ -476,33 +449,10 @@ BuildRaresFrame = function()
         if isMin then
             if f._scroll      then f._scroll:Hide()   end
             if f._dragger     then f._dragger:Hide()   end
-            if headerBottom then
-                local left = f:GetLeft()
-                local bottom = f:GetBottom()
-                if left and bottom then
-                    f:ClearAllPoints()
-                    f:SetPoint("BOTTOMLEFT", UIParent, "BOTTOMLEFT", left, bottom)
-                    if MR.db then MR:SetWindowLayoutValue("raresPos", { point = "BOTTOMLEFT", relPoint = "BOTTOMLEFT", x = left, y = bottom }) end
-                end
-            else
-                local left = f:GetLeft()
-                local top  = f:GetTop()
-                if left and top then
-                    f:ClearAllPoints()
-                    f:SetPoint("TOPLEFT", UIParent, "BOTTOMLEFT", left, top)
-                    if MR.db then MR:SetWindowLayoutValue("raresPos", { point = "TOPLEFT", relPoint = "BOTTOMLEFT", x = left, y = top }) end
-                end
-            end
+            SyncManagedFramePos(f, "raresPos", headerBottom and "bottom" or "top")
             ApplyFrameHeight(f, TITLE_H)
         else
-            if headerBottom then
-                local left = f:GetLeft()
-                local bottom = f:GetBottom()
-                if left and bottom then
-                    f:ClearAllPoints()
-                    f:SetPoint("BOTTOMLEFT", UIParent, "BOTTOMLEFT", left, bottom)
-                end
-            end
+            SyncManagedFramePos(f, "raresPos", headerBottom and "bottom" or "top")
             if f._scroll  then f._scroll:Show()  end
             if f._dragger then f._dragger:Show()  end
             ApplyFrameHeight(f, MR.db and MR.db.profile.raresHeight or DEFAULT_H)