Skip to content

audit: add LEP-6 foundation storage-truth scaffolding#117

Open
j-rafique wants to merge 1 commit intomasterfrom
LEP-6-foundation
Open

audit: add LEP-6 foundation storage-truth scaffolding#117
j-rafique wants to merge 1 commit intomasterfrom
LEP-6-foundation

Conversation

@j-rafique
Copy link
Copy Markdown
Contributor

No description provided.

@j-rafique j-rafique self-assigned this Apr 20, 2026
@roomote-v0
Copy link
Copy Markdown

roomote-v0 bot commented Apr 20, 2026

Rooviewer Clock   See task

Reviewed the LEP-6 storage-truth foundation scaffolding. The PR is well-structured with clean proto definitions, proper KV store indexing (including secondary indices for heal ops), comprehensive query/state management, and good test coverage. Two minor items flagged:

  • Placeholder msg handlers use ErrInvalidSigner for nil-request validation -- semantically misleading error code for clients
  • devnet/go.sum adds a self-referential LumeraProtocol/lumera v1.10.0 checksum entry -- likely dead weight from go mod tidy

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

Comment on lines +12 to +13
if req == nil {
return nil, errorsmod.Wrap(types.ErrInvalidSigner, "empty request")
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All three placeholder handlers wrap ErrInvalidSigner (error code 1) for nil-request and empty-creator checks. For the nil-request case this is semantically misleading -- a nil request is an invalid argument, not an invalid signer. Clients that match on error codes will misclassify the failure. Consider using a dedicated ErrInvalidRequest or sdkerrors.ErrInvalidRequest for the nil check, and reserving ErrInvalidSigner for the creator-specific validation.

Fix it with Roo Code or mention @roomote and request a fix.

Comment thread devnet/go.sum
github.com/GoogleCloudPlatform/opentelemetry-operations-go/internal/resourcemapping v0.50.0 h1:ig/FpDD2JofP/NExKQUbn7uOSZzJAQqogfqluZK4ed4=
github.com/GoogleCloudPlatform/opentelemetry-operations-go/internal/resourcemapping v0.50.0/go.mod h1:otE2jQekW/PqXk1Awf5lmfokJx4uwuqcj1ab5SpGeW0=
github.com/Knetic/govaluate v3.0.1-0.20171022003610-9aa49832a739+incompatible/go.mod h1:r7JcOSlj0wfOMncg0iLm8Leh48TZaKVeNIfJntJ2wa0=
github.com/LumeraProtocol/lumera v1.10.0/go.mod h1:p2sZZG3bLzSBdaW883qjuU3DXXY4NJzTTwLywr8uI0w=
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds a github.com/LumeraProtocol/lumera v1.10.0/go.mod entry to devnet/go.sum, which is a self-referential dependency (the devnet module depending on its own parent repo at a tagged version). This is likely an artifact of running go mod tidy with a stale module cache or a replace directive that was temporarily removed. If the devnet module uses a replace directive to point at the local ../ path, this checksum line is dead weight and could cause confusion if the tagged version diverges from the local code. Worth confirming this entry is intentional.

Fix it with Roo Code or mention @roomote and request a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant