audit: add LEP-6 foundation storage-truth scaffolding#117
audit: add LEP-6 foundation storage-truth scaffolding#117
Conversation
Reviewed the LEP-6 storage-truth foundation scaffolding. The PR is well-structured with clean proto definitions, proper KV store indexing (including secondary indices for heal ops), comprehensive query/state management, and good test coverage. Two minor items flagged:
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
| if req == nil { | ||
| return nil, errorsmod.Wrap(types.ErrInvalidSigner, "empty request") |
There was a problem hiding this comment.
All three placeholder handlers wrap ErrInvalidSigner (error code 1) for nil-request and empty-creator checks. For the nil-request case this is semantically misleading -- a nil request is an invalid argument, not an invalid signer. Clients that match on error codes will misclassify the failure. Consider using a dedicated ErrInvalidRequest or sdkerrors.ErrInvalidRequest for the nil check, and reserving ErrInvalidSigner for the creator-specific validation.
Fix it with Roo Code or mention @roomote and request a fix.
| github.com/GoogleCloudPlatform/opentelemetry-operations-go/internal/resourcemapping v0.50.0 h1:ig/FpDD2JofP/NExKQUbn7uOSZzJAQqogfqluZK4ed4= | ||
| github.com/GoogleCloudPlatform/opentelemetry-operations-go/internal/resourcemapping v0.50.0/go.mod h1:otE2jQekW/PqXk1Awf5lmfokJx4uwuqcj1ab5SpGeW0= | ||
| github.com/Knetic/govaluate v3.0.1-0.20171022003610-9aa49832a739+incompatible/go.mod h1:r7JcOSlj0wfOMncg0iLm8Leh48TZaKVeNIfJntJ2wa0= | ||
| github.com/LumeraProtocol/lumera v1.10.0/go.mod h1:p2sZZG3bLzSBdaW883qjuU3DXXY4NJzTTwLywr8uI0w= |
There was a problem hiding this comment.
This adds a github.com/LumeraProtocol/lumera v1.10.0/go.mod entry to devnet/go.sum, which is a self-referential dependency (the devnet module depending on its own parent repo at a tagged version). This is likely an artifact of running go mod tidy with a stale module cache or a replace directive that was temporarily removed. If the devnet module uses a replace directive to point at the local ../ path, this checksum line is dead weight and could cause confusion if the tagged version diverges from the local code. Worth confirming this entry is intentional.
Fix it with Roo Code or mention @roomote and request a fix.
No description provided.