LoadData was being called twice from InitializeImage #2079
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI gfxreconstruct build queued with queue ID 397615. |
|
CI gfxreconstruct build # 6356 running. |
|
CI gfxreconstruct build # 6356 passed. |
| @@ -181,8 +181,6 @@ VkResult VulkanResourceInitializer::InitializeImage(VkDeviceSize dat | |||
|
|
|||
| if (result == VK_SUCCESS) | |||
| { | |||
| result = LoadData(data_size, data, staging_buffer_data); | |||
|
|
|||
| if (result == VK_SUCCESS) | |||
There was a problem hiding this comment.
I think you can remove the inner if.
AcquireInitializedStagingBuffer will call LoadData so InitializeImage does not need to explicitly call it again.
panos-lunarg
force-pushed
the
do_not_LoadData_twice_in_InitializeImage
branch
from
0f86544 to
e6ad108
Compare
|
CI gfxreconstruct build queued with queue ID 397665. |
|
CI gfxreconstruct build # 6358 running. |
|
CI gfxreconstruct build # 6358 passed. |
|
This is included in #2081 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AcquireInitializedStagingBuffer will call LoadData so InitializeImage does not need to explicitly call it again.