Android Test App Builds #2093
Open
Android Test App Builds #2093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI gfxreconstruct build queued with queue ID 404518. |
|
CI gfxreconstruct build queued with queue ID 404520. |
Debug triangle on local phone
beau-lunarg
force-pushed
the
beau-test-app-android
branch
from
f2b37a3 to
212df76
Compare
|
CI gfxreconstruct build queued with queue ID 404522. |
|
CI gfxreconstruct build queued with queue ID 404566. |
|
CI gfxreconstruct build queued with queue ID 404589. |
beau-lunarg
requested review from
MarkY-LunarG and
bradgrantham-lunarg
and removed request for
MarkY-LunarG and
bradgrantham-lunarg
|
CI gfxreconstruct build # 6416 running. |
|
CI gfxreconstruct build # 6416 passed. |
| std::vector<char> readFile(const std::string& filename, android_app* app) { | ||
| AAsset *file = AAssetManager_open(app->activity->assetManager, filename.c_str(), | ||
| AASSET_MODE_BUFFER); | ||
| size_t fileLength = AAsset_getLength(file); |
There was a problem hiding this comment.
Better check file != nullptr before continuing.
Open
|
CI gfxreconstruct build queued with queue ID 409991. |
|
CI gfxreconstruct build # 6473 running. |
|
CI gfxreconstruct build # 6473 passed. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.