Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a --no-index option to gfxrecon-convert #2100

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

marius-pelegrin-arm
Copy link
Contributor

@marius-pelegrin-arm marius-pelegrin-arm commented Mar 28, 2025

When comparing different traces that are very similar, we may want to convert the traces using the jsonl format to look directly at the call differences.
However, some data in the output of gfxrecon-convert tends to "pollute" the difference, like the block index at the begining of each line.

This commit implements a --no-index option to remove the block index at the begining of each block in the output of gfxrecon-convert

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 407198.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 407200.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 6453 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 6453 passed.

@MarkY-LunarG
Copy link
Contributor

MarkY-LunarG commented Apr 9, 2025

To me, I would like this to be named more like --no-index. And then when you get a few things together, you could make a --bare which enabled those multiple options once you have them in place. I think "bare" alone doesn't make much sense at this point.

@bradgrantham-lunarg, what do you think?

@bartosz-muszarski-arm
Copy link
Contributor

That's actually how this change started, as --no-index.
But since the goal in the end is to make the output diff-friendly, not remove "index" in particular, but anything that might introduce any noise in the diffs in the future, it was renamed to reflect its actual purpose.
That way we can rely on this in automation today.
Would it be really useful to have separate options for these fields anyway?

@MarkY-LunarG
Copy link
Contributor

I personally would like to have the options separate and an option to enable them all as well. Like --bare just forces on all the "messy options". The reason why is I could see people wanting to enable only some of the bare options and always forcing every option at once would be a pain to tweak out. So if you want, do both --no-index and then --bare which only turns on --no-index for now, but will grow in the future.

When comparing different traces that are very similar, we may
want to convert the traces using the `jsonl` format to look
directly at the call differences.
However, some data in the output of `gfxrecon-convert` tends
to "pollute" the difference, like the block index at the begining
of each line.

This commit implements a `--no-index` option to remove the block
index at the begining of each block in the output of
`gfxrecon-convert`

Change-Id: I96d005fac1342780782edc68a26c8c8cab311894
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 420490.

@marius-pelegrin-arm
Copy link
Contributor Author

Hello ! So I put aside the --bare option for the moment and just renamed it --no-index =)

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 6617 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 6617 passed.

@marius-pelegrin-arm marius-pelegrin-arm changed the title Add a --bare option to gfxrecon-convert Add a --no-index option to gfxrecon-convert Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants