Skip to content

Conversation

@M-Colley
Copy link
Owner

Summary

  • run the workflow dependency installation step inside an R shell so install.packages() executes successfully
  • ensure easystats is preinstalled alongside the other test dependencies so sourcing r_functionality.R no longer fails

Testing

  • Not run (R is not available in the execution environment)

Codex Task

@M-Colley M-Colley merged commit b0f2084 into main Nov 16, 2025
0 of 2 checks passed
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +15 to +21
- name: Install dependencies
shell: Rscript {0}
run: |
install.packages(c(
"testthat", "tidyverse", "rstatix", "ggstatsplot", "ggsignif",
"see", "ggpmisc", "writexl", "readxl", "emoa", "effectsize",
"easystats"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Install curl before running tests

The workflow step at lines 15‑21 only installs a handful of CRAN packages before running the suite, but the helper sets options(rcode.auto_install = FALSE) so tests rely entirely on the packages preinstalled here. The new basic utility helpers behave test (tests/testthat/test_r_functionality.R:97‑99) stubs curl::has_internet via with_mock. On a clean runner where the curl package isn’t already available (it’s not a recommended/base package), referencing curl::has_internet fails before the mock is applied, so the tests abort and the workflow can never turn green. Please add curl (and any other packages referenced directly in the tests) to this install.packages list so CI reliably succeeds.

Useful? React with 👍 / 👎.

@M-Colley M-Colley deleted the codex/add-tests-and-effect-sizes-validation-d4dftg branch November 23, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants