Skip to content

Improve handling to parse header data#32

Merged
micah-prime merged 2 commits intoM3Works:mainfrom
jomey:meta_parse
Nov 17, 2025
Merged

Improve handling to parse header data#32
micah-prime merged 2 commits intoM3Works:mainfrom
jomey:meta_parse

Conversation

@jomey
Copy link
Copy Markdown
Contributor

@jomey jomey commented Oct 9, 2025

Examples of the tests describe this best, which were written with the help of AI.

Add a colon to the error message to better identify the column that was not
matched. Before it was hard to discern the actual column name.
@jomey jomey force-pushed the meta_parse branch 3 times, most recently from b9fbf27 to 0678990 Compare November 14, 2025 21:21
@micah-prime micah-prime self-requested a review November 15, 2025 02:50
@micah-prime
Copy link
Copy Markdown
Contributor

@jomey it looks like there are some test failures on this one

Add handling for headers that are empty or a sequence of empty separators.
Also improve handling of different header line separators (\n or \r)
@jomey
Copy link
Copy Markdown
Contributor Author

jomey commented Nov 15, 2025

@jomey it looks like there are some test failures on this one

Taken care of

@micah-prime micah-prime merged commit b151b8c into M3Works:main Nov 17, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants