Add setup.py for easy installation and usage - #4
Open
francisco-dlp wants to merge 13 commits into
Open
Conversation
Member
|
Thanks for this PR, and sorry for not getting back to you sooner. You're right, using a proper setup.py is in this day and age a much cleaner way to handle a package like this. I've got a couple of changes on top of your commits. I'll push those soon. One question. Is it just a typo, or intentional that you prefer |
Author
|
That was a typo, sorry. Are you still considering merging this PR? |
Member
|
Yes.. I would. Would you have time to update the PR, and fix the typo? |
Author
|
Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added a
setup.pyfile for easy installation. It enables usingtpx3HitParserfrom anywhere without adding the installation folder toPATH. For that I've slightly changed the package structure and import style.Example of usage:
I have also updated
.gitignorewith GitHub's Python one.