Skip to content

Add support for chat formatting (bold, italic, underline, etc) #2851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Add support for chat formatting (bold, italic, underline, etc) #2851

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
34e6567
Add formatting to console output
Skylandia Jan 31, 2025
c79b1cf
Simple formatting support for discord
Skylandia Jan 31, 2025
c1e5141
fixes
Skylandia Mar 8, 2025
7faca4f
Merge branch 'MCCTeam:master' into chat-formatting
Skylandia Jun 12, 2025
9d626e1
don't use buggy discord formatting by default
Jun 12, 2025
d1c885c
cleanup output and fix formatting sometimes not being applied
Skylandia Jun 13, 2025
4462ef0
don't ignore the reset character
Skylandia Jun 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions MinecraftClient/ChatBots/DiscordBridge.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
using System.Collections.Generic;
using System.IO;
using System.Linq;
using System.Text.RegularExpressions;
using System.Threading.Tasks;
using Brigadier.NET.Builder;
using DSharpPlus;
Expand Down Expand Up @@ -177,6 +178,15 @@ private void Disconnect()
return instance;
}

private static string GetDiscordText(string text) {
text = Regex.Replace(text, "§l(.*?§r)", "**$1**");
text = Regex.Replace(text, "§m(.*?§r)", "~~$1~~");
text = Regex.Replace(text, "§n(.*?§r)", "__$1__");
text = Regex.Replace(text, "§o(.*?§r)", "*$1*");
text = Regex.Replace(text, "§.", "");
return text;
}

public override void GetText(string text)
{
if (!CanSendMessages())
Expand Down
114 changes: 85 additions & 29 deletions MinecraftClient/Protocol/Message/ChatParser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,22 +406,49 @@ private static string TranslateString(string rulename, List<string> using_data)
else return "[" + rulename + "] " + string.Join(" ", using_data);
}

private readonly static Dictionary<string, string> FormattingCodes = new() {
{"obfuscated", "k"},
{"bold", "l"},
{"strikethrough", "m"},
{"underline", "n"},
{"italic", "o"},
};

/// <summary>
/// Use a JSON Object to build the corresponding string
/// </summary>
/// <param name="data">JSON object to convert</param>
/// <param name="colorcode">Allow parent color code to affect child elements (set to "" for function init)</param>
/// <param name="formatting">Allow parent formatting codes to affect child elements (set to "" for function init)</param>
/// <param name="links">Container for links from JSON serialized text</param>
/// <returns>returns the Minecraft-formatted string</returns>
private static string JSONData2String(Json.JSONData data, string colorcode, List<string>? links)
private static string JSONData2String(Json.JSONData data, string formatting, List<string>? links)
{
string message = "";
string extra_result = "";
switch (data.Type)
{
case Json.JSONData.DataType.Object:
if (data.Properties.ContainsKey("color"))
{
colorcode = Color2tag(JSONData2String(data.Properties["color"], "", links));
// Remove old colors
formatting = Regex.Replace(formatting, "§[0-9a-f]", "");
// Add the new color
formatting += Color2tag(JSONData2String(data.Properties["color"], "", links));
}

foreach (var pair in FormattingCodes)
{
if (data.Properties.ContainsKey(pair.Key))
{
if (data.Properties[pair.Key].StringValue == "true")
{
formatting += "§" + pair.Value;
}
else if (data.Properties[pair.Key].StringValue == "false")
{
formatting = formatting.Replace("§" + pair.Value, "");
}
}
}

if (data.Properties.ContainsKey("clickEvent") && links != null)
Expand All @@ -440,12 +467,12 @@ private static string JSONData2String(Json.JSONData data, string colorcode, List
{
Json.JSONData[] extras = data.Properties["extra"].DataArray.ToArray();
foreach (Json.JSONData item in extras)
extra_result = extra_result + JSONData2String(item, colorcode, links) + "§r";
extra_result += JSONData2String(item, "§r" + formatting, links);
}

if (data.Properties.ContainsKey("text"))
{
return colorcode + JSONData2String(data.Properties["text"], colorcode, links) + extra_result;
message = JSONData2String(data.Properties["text"], formatting, links);
}
else if (data.Properties.ContainsKey("translate"))
{
Expand All @@ -457,43 +484,76 @@ private static string JSONData2String(Json.JSONData data, string colorcode, List
Json.JSONData[] array = data.Properties["with"].DataArray.ToArray();
for (int i = 0; i < array.Length; i++)
{
using_data.Add(JSONData2String(array[i], colorcode, links));
using_data.Add(JSONData2String(array[i], formatting, links));
}
}

return colorcode +
TranslateString(JSONData2String(data.Properties["translate"], "", links), using_data) +
extra_result;
message = TranslateString(JSONData2String(data.Properties["translate"], formatting, links), using_data);
}
else return extra_result;
break;

case Json.JSONData.DataType.Array:
string result = "";
foreach (Json.JSONData item in data.DataArray)
{
result += JSONData2String(item, colorcode, links);
result += JSONData2String(item, formatting, links);
}

return result;
message = result;
break;

case Json.JSONData.DataType.String:
return colorcode + data.StringValue;
message = data.StringValue;
break;
}

return "";
// Formatting before a reset character is ignored
formatting = Regex.Replace(formatting, ".*(§r.*)", "$1");
return formatting + message + extra_result;
}

private static string NbtToString(Dictionary<string, object> nbt)
private static string NbtToString(Dictionary<string, object> nbt, string formatting)
{
if (nbt.Count == 1 && nbt.TryGetValue("", out object? rootMessage))
{
// Nameless root tag
return (string)rootMessage;
return formatting + (string)rootMessage;
}

string message = string.Empty;
string colorCode = string.Empty;
StringBuilder extraBuilder = new StringBuilder();

// Build the formatting prefix first so extras can inherit it
foreach (var kvp in nbt)
{
string key = kvp.Key;
object value = kvp.Value;

switch (key)
{
case "color":
{
if (nbt.TryGetValue("color", out object color))
{
formatting += Color2tag((string)color);
}
}
break;
case "italic":
case "bold":
case "underline":
case "strikethrough":
{
if ((byte) value > 0)
{
formatting += "§" + FormattingCodes[key];
} else {
formatting = formatting.Replace("§" + FormattingCodes[key], "");
}
}
break;
}
}

foreach (var kvp in nbt)
{
string key = kvp.Key;
Expand Down Expand Up @@ -521,7 +581,7 @@ private static string NbtToString(Dictionary<string, object> nbt)
_ => (Dictionary<string, object>)extras[i]
};

extraBuilder.Append(NbtToString(extraDict) + "§r");
extraBuilder.Append(NbtToString(extraDict, "§r" + formatting));
}
}
break;
Expand Down Expand Up @@ -554,18 +614,14 @@ private static string NbtToString(Dictionary<string, object> nbt)
}
}
break;
case "color":
{
if (nbt.TryGetValue("color", out object color))
{
colorCode = Color2tag((string)color);
}
}
break;
}
}

return colorCode + message + extraBuilder.ToString();
return formatting + message + extraBuilder.ToString();
}
private static string NbtToString(Dictionary<string, object> nbt)
{
return NbtToString(nbt, String.Empty);
}
}
}
}