Skip to content

Conversation

ThexXTURBOXx
Copy link
Contributor

This PR changes the following:

  • Adds an option for SRG obfuscation (very useful if 1.5.2 mods should also support 1.5 and 1.5.1 - however this would also need to be implemented as a separate namespace in the 1.5.2 mappings)
  • Fixes FlatLaf through disabling minimisation
  • Updates the German translations
  • Migrates to toml-based library and plugin declarations

@PhoenixVX
Copy link
Member

  1. LGTM though is this really necessary?
  2. What is wrong with minimization? It works in my testing.
  3. LGTM
  4. LGTM

Will need to downgrade Shadow as it needs Java 11+ on the latest versions (which is why the build failed).

@ThexXTURBOXx
Copy link
Contributor Author

  1. Necessary? Probably no. But it's a feature that the original MCP also had and I am always using to build Block Helper - it does not have any downsides, just advantages.
  2. When running in my IDE, it works fine. However, when running the built GUI, it complains about missing classes. It does also not save too much space (only like 33% - is it worth it?)

Will downgrade shadow plugin again - simply forgot about this change!

@ThexXTURBOXx
Copy link
Contributor Author

ThexXTURBOXx commented Apr 17, 2025

Resolved the discussions - I left the comment after the minimize(), since it 100% does not work on my machine.
If it works on yours, feel free to remove it or tell me again and I will remove it :)

There are many, many, many errors here, btw. This is just the first snippet:

grafik

@PhoenixVX PhoenixVX merged commit fd1c4e0 into MCPHackers:main May 23, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants