MAINT: mkdtemp 3.12 support - #4309
Merged
Merged
Conversation
* force the use of a relative path for `mkdtemp` in our source code because, from the Python `3.12` release notes: > `tempfile.mkdtemp() now always returns an absolute path, even if the argument provided to the dir parameter is a relative path.` * with this patch, the full testsuite now passes on Python `3.12.0` (which is now out) when combined with MDAnalysisgh-4301 and MDAnalysisgh-4300 (though see my cautions about thread safety/concurrency for the latter) * this fixes the 1 remaining failure with 3.12: `MDAnalysisTests/analysis/test_hole2.py::TestCheckAndFixLongFilename::test_symlink_dir` [skip cirrus]
Linter Bot Results:Hi @tylerjereddy! Thanks for making this PR. We linted your code and found the following: There are currently no issues detected! 🎉 |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4309 +/- ##
==========================================
Coverage 93.40% 93.40%
==========================================
Files 170 184 +14
Lines 22257 23365 +1108
Branches 4071 4071
==========================================
+ Hits 20790 21825 +1035
- Misses 951 1024 +73
Partials 516 516
☔ View full report in Codecov by Sentry. |
Member
|
Thanks @tylerjereddy ! I'll try to get the py3.12 CI PR updated tomorrow and we can start merging in all your PRs. |
richardjgowers
approved these changes
Oct 3, 2023
IAlibay
approved these changes
Oct 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mkdtempin our source code because, from the Python3.12release notes:with this patch, the full testsuite now passes on (x86_64 Linux) Python
3.12.0(which is now out) when combined with MAINT: Python 3.12 cleanups part 2 #4301 and MAINT: Python 3.12 support improve #4300 (though see my cautions about thread safety/concurrency for the latter)this fixes the 1 remaining failure with 3.12:
MDAnalysisTests/analysis/test_hole2.py::TestCheckAndFixLongFilename::test_symlink_dir[skip cirrus]
📚 Documentation preview 📚: https://mdanalysis--4309.org.readthedocs.build/en/4309/