add new rotating 40Msun to cc test_suite for testing #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
try with v_flag = .true. in inlist_to_cc
|
fyi, I switched off u_flag and stuck with v_flag in the last commit, although I kept the options for u_flag available. The model seems to work fine, although I turned off drag_coefficient in inlist_to_cc as damping the waves generated from burning seems problematic and might even crash the model. |
Previously we had min_convective_gap=1 which imposes at least 1 pressure scale height between convective zones and merges convective zones separated by less. This lead to a massive c12 injestion which is likely unphysical. I've now set this to 0.1, which prevents that injestion and makes the model run more smoothly. Minor tweaks in the README.rst for readability (correcting also a spurious quoted Z).
Debraheem
added
the
release-blocker
|
This test case just needs some minor tweaks and some clean up and it should be ready for a merge. @aurimontem , please let me know if you have any opinions. |
|
build failure is lfs related, just ignore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It had been brought up many times that we should have a test case that demonstrates the evolution of a rotating model to CC. Here is a new test case for a 40Msun rotating model that evolves from pms to cc. This is a tweaked version of the model shared in this issue #651, from which this pr is sponsored. Since it is not always so easy to hit cc, this test_suite uses u_flag for the evolution to CC. I welcome and encourage anyone to modify this test_suite how they see fit and take ownership! One could even try using u_flag earlier if you'd like, although you might see some pulsation development at the surface.