adjust delta_Pg #778
Open
adjust delta_Pg #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Debraheem
added
enhancement
Debraheem
commented
Feb 9, 2025
star/private/report.f90
Outdated
| if (s% delta_Pg_mode_freq > 0) nu_for_delta_Pg = s% delta_Pg_mode_freq | ||
| call get_delta_Pg(s, nu_for_delta_Pg, s% delta_Pg) | ||
| if ( .not. s% delta_Pg_traditional) then | ||
| if (s% delta_Pg_mode_freq > 0) nu_for_delta_Pg = s% delta_Pg_mode_freq |
There was a problem hiding this comment.
Should I move this before the if statement?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolving #467 raised by @earlbellinger, by adopting @warrickball's suggestion. I introduced a logical control that allows users to choose which method they'd like to use for calculating delta_Pg. The default will now be
delta_Pg_traditional = .true..I attempted to document the controls and included a changelog. As I am not an asteroseismologist, I'd appreciate someone double checking my explanations.
If this passes testing, we can merge.