Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add conv_vel cs limit to mlt/tdc #780

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

Debraheem
Copy link
Member

To make use of deprecated controls max_conv_vel_div_csound and max_conv_vel_div_csound_maxq by request #776 and #373. This pr introduces a cs limiter, initially designed by adam/pablo for tdc. We can also introduce a limit for mlt, similar to the one present in previous releases. At the moment, this pr only includes the cs limiter for conv_vel inside TDC.

This pr has also highlighted some potential issues in the building of the pre_ms_model. We are unable to call s% q(k) inside mlt when building the pre_ms_model because it is not yet set. In fact, I've marked a couple statements inside the pms build routine which could be problematic.

I don't mind removing max_conv_vel_div_csound_maxq , but ideally, we can call q(k) inside the mlt_routine during the pms model creation.

worst case, we don't introduce either of these controls, but in that case we should remove them all together.

@Debraheem Debraheem added documentation Improvements or additions to documentation enhancement New feature or request tdc labels Feb 9, 2025
@Debraheem Debraheem requested a review from pmocz February 9, 2025 04:56
@Debraheem Debraheem self-assigned this Feb 9, 2025
Copy link
Member Author

@Debraheem Debraheem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, q and dq are set before this subroutine which calls mlt/tdc to create the pms model.

       call look_for_brackets(lnd, dlnd, lnd1, lnd3, pre_ms_f, y1, y3, &
               imax, pre_ms_lrpar, rpar, pre_ms_lipar, ipar, ierr)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request tdc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants