Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make use of deprecated controls
max_conv_vel_div_csound
andmax_conv_vel_div_csound_maxq
by request #776 and #373. This pr introduces a cs limiter, initially designed by adam/pablo for tdc. We can also introduce a limit for mlt, similar to the one present in previous releases. At the moment, this pr only includes the cs limiter for conv_vel inside TDC.This pr has also highlighted some potential issues in the building of the pre_ms_model. We are unable to call
s% q(k)
inside mlt when building the pre_ms_model because it is not yet set. In fact, I've marked a couple statements inside the pms build routine which could be problematic.I don't mind removing
max_conv_vel_div_csound_maxq
, but ideally, we can call q(k) inside the mlt_routine during the pms model creation.worst case, we don't introduce either of these controls, but in that case we should remove them all together.