Adding support to max_conv_vel_div_csound (non-TDC MLT options) and adding opacity_min control #781
+51
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rol opacity_min to introduce opacity floor
Debraheem
requested review from
orlox,
mjoyceGR,
Debraheem,
aurimontem,
wmwolf,
evbauer,
fxt44,
annethoul,
rsmolec,
aarondotter,
rhdtownsend and
warrickball
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #776, the control
max_conv_vel_div_csoundis mentioned in the documentation but not used. I added support for this control to limit convection velocities for non-TDC MLT options. The main motivation for using this control relies on the assumptions on MLT prescriptions, as the ones from Cox and Mihalas, are not valid for supersonic convection velocities.As well I add in this patch the control
opacity_minto be able to have an opacity floor. The motivation for this control comes from the underestimation of line opacities from expanding material by the Ferguson et al. (2005) tables (see section 2.2 in Morozova et al. (2015) for a more detailed discussion).