Skip to content

Conversation

@simmsa
Copy link
Contributor

@simmsa simmsa commented Jun 10, 2025

Windows and unix tests are failing in PR #167. This pr is investigating the tests/actions to determine the root cause of the failures.

Windows failures.

Failure Summary:

     Name                                                                Failed  Incomplete  Reason(s)
    =================================================================================================================
     Loads_TestExtreme/test_mler_coefficients                                        X       Filtered by assumption.
    -----------------------------------------------------------------------------------------------------------------
     Loads_TestExtreme/test_short_term_extremes                            X         X       Errored.
    -----------------------------------------------------------------------------------------------------------------
     Loads_TestExtreme/test_long_term_extreme                              X         X       Errored.
    -----------------------------------------------------------------------------------------------------------------
     Loads_TestLoads/test_bin_statistics                                             X       Filtered by assumption.
    -----------------------------------------------------------------------------------------------------------------
     Wave_TestPerformance/test_power_performance_workflow                  X         X       Failed by assertion.
    -----------------------------------------------------------------------------------------------------------------
     Wave_TestResourceMetrics/test_metrics_HsP                             X         X       Failed by assertion.
    -----------------------------------------------------------------------------------------------------------------
     Wave_TestResourceMetrics/test_metrics_AH                              X         X       Failed by assertion.
    -----------------------------------------------------------------------------------------------------------------
     Wave_TestResourceMetrics/test_plot_environmental_contour_multiyear              X       Filtered by assumption.
    -----------------------------------------------------------------------------------------------------------------
     Wave_TestResourceSpectrum/test_surface_elevation_seed                           X       Filtered by assumption.
    -----------------------------------------------------------------------------------------------------------------
     Wave_TestResourceSpectrum/test_surface_elevation_phasing                        X       Filtered by assumption.
    -----------------------------------------------------------------------------------------------------------------
     Wave_TestResourceSpectrum/test_surface_elevation_moments              X         X       Failed by assertion.

Specific Failures:

================================================================================
Error occurred in Loads_TestExtreme/test_short_term_extremes and it did not run to completion.
    ---------
    Error ID:
    ---------
    'MATLAB:duration:MatrixDivisionNotDefined'
    --------------
    Error Details:
    --------------
    Error using /
    The denominator in matrix division for duration arrays must be a real scalar double value.
    
    Error in short_term_extreme (line 48)
            nst = round(length(peaks) * t_st / duration);
    
    Error in Loads_TestExtreme/test_short_term_extremes (line 137)
                    cdfs(i) = short_term_extreme(txtfile(:,1), txtfile(:,2), t_st, methods(i), x, "cdf");
================================================================================
.
================================================================================
Error occurred in Loads_TestExtreme/test_long_term_extreme and it did not run to completion.
    ---------
    Error ID:
    ---------
    'MATLAB:duration:MatrixDivisionNotDefined'
    --------------
    Error Details:
    --------------
    Error using /
    The denominator in matrix division for duration arrays must be a real scalar double value.
    
    Error in short_term_extreme (line 48)
            nst = round(length(peaks) * t_st / duration);
    
    Error in Loads_TestExtreme/test_long_term_extreme (line [149](https://github.com/MHKiT-Software/MHKiT-MATLAB/actions/runs/15547016193/job/43770352651#step:15:150))
                ste1 = short_term_extreme(txtfile(:,1), txtfile(:,2), t_st, "peaks_weibull", z, "cdf");
================================================================================

Failures on ubuntu cache population job:

Error occurred in Wave_TestResourceSpectrum/test_jonswap_spectrum and it did not run to completion.
    ---------
    Error ID:
    ---------
    'MATLAB:undefinedVarOrClass'
    --------------
    Error Details:
    --------------
    Unable to resolve the name 'py.mhkit.wave.resource.peak_period'.

@simmsa simmsa requested a review from MShabara June 11, 2025 16:09
@simmsa simmsa marked this pull request as ready for review June 11, 2025 16:09
@simmsa
Copy link
Contributor Author

simmsa commented Jun 11, 2025

@MShabara this ignores some specific versions of MATLAB/Python/OS that are failing for reasons not related to the MHKiT code.

LMK if you have any questions or suggestions for improvement.

@simmsa
Copy link
Contributor Author

simmsa commented Jun 24, 2025

@MShabara do you have time to review this?

@simmsa simmsa merged commit 31388bb into MHKiT-Software:develop Jul 1, 2025
30 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant