- 
                Notifications
    You must be signed in to change notification settings 
- Fork 24
v1.0.0 Release #184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.0.0 Release #184
Conversation
Fixing: ``` Python Error: ImportError: DLL load failed while importing pyexpat: The operating system cannot run %1. ```
Fix Failing Tests:
* Unix/MacOS: 
  * Pin Ubuntu version to `ubuntu-22.04`
  * Explicitly set LD_PRELOAD environment variable
  * Skip Failing:
    * Ubuntu, python 3.10, matlab R2023a
  * All other matrix tests pass
* Windows:
  * Set PYBIND11_NO_ASSERT_GIL_HELD_INCREF_DECREF=1
    * Attempt to fix python call from MATLAB
  * Skip:
    * Python 3.10 R2023a
    The get(0,'Format') calls were originally added to support debugging printf statements (now removed). Since format only affects display and not calculation precision, these commands are unnecessary for the programmatic numerical comparisons performed by these methods.
…onversion - Replace datestr() with string() for datetime formatting - Replace datenum(datestr()) with direct datenum() conversion for performance - Maintains same output formats while using modern MATLAB functions
…iles - Remove unused datenum variables in QC_Test.m - Replace datenum arithmetic with datetime operations and seconds() conversion - Replace Unix epoch conversion with posixtime in River_TestIO.m
- Update plot_joint_probability_distribution.m to use colormap(CMaPType, 256) - Update plot_rose.m to use colormap(CMaPType, 256) - Update plot_matrix.m to use colormap(flipud(hot(256))) This ensures consistent behavior across MATLAB versions and uses the modern 256-color standard instead of the legacy 64-color default.
Acoustics Module Standardization
Acoustics module
WEC-Sim Power performance example
Feature: Add Dolfyn Turbulence Functionality
Prep v1.0 release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At a high level, looks good to me. In the future, we should figure out a solid method for keeping track of all the changes to make release note generation easier. I think we are good to merge assuming all the tests pass!
| @hivanov-nrel, thank you for reviewing! Agreed on the release notes. It seems possible to create a template for each pull request. I can look into that. | 
Version 1.0.0
Release Highlights
PR #174 - Acoustics Module
plot_spectrogramPR #176 - Wave Module Native MATLAB Implementation
PR #153 - Mooring Module
PR #173 - Dolfyn Turbulence Functionality
PR #175 - WEC-Sim Power Performance Example
PR #170 - WDRT Final Tasks
automatic_hs_thresholdandreturn_year_valuefunctionsPR #169 - Code Compatibility Improvements
Bug Fixes
environmental_contours_example.mlxdue tospectra_to_pandasreturn variable #152 - Fix dimensionality differences in environmental_contours_example - @simmsa