Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove doubled X-XSS-Protection Header #204

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Remove doubled X-XSS-Protection Header #204

merged 1 commit into from
Jan 13, 2025
+0 −1

Conversation

marjatech
Copy link
Contributor

@marjatech marjatech commented Jan 9, 2025 •
edited
Loading

since it gets already set by MISP itself. Code

OWASPs recommendation for this header is:

Do not set this header or explicitly turn it off. X-XSS-Protection: 0

image

@marjatech
remove doubled X-XSS-Protection Header
3a219de 
since it gets already set by MISP itself
@ostefano
Copy link
Collaborator

ostefano commented Jan 12, 2025 •
edited
Loading

@marjatech this is added by MISP only for REST calls though, right?

@ostefano ostefano self-requested a review January 12, 2025 10:55
@ostefano ostefano added enhancement New feature or request question Further information is requested labels Jan 12, 2025
ostefano
ostefano reviewed Jan 12, 2025
View reviewed changes
Copy link
Collaborator

@ostefano ostefano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my other comment

@marjatech
Copy link
Contributor Author

marjatech commented Jan 13, 2025 •
edited
Loading

I think it's added only for non-REST calls, which should be fine.
And as i wrote OWASPs recommendation is anyway not to set it at all or set it to 0.

@ostefano ostefano merged commit 2b9390e into MISP:master Jan 13, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ostefano ostefano ostefano left review comments

Assignees

@marjatech marjatech

Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marjatech @ostefano