Document missing core operations from recent optimizer PRs - #558
Merged
Conversation
Copilot
AI
changed the title
[WIP] Review and create issue for mlx.core.subtract implementation
Document missing core operations from recent optimizer PRs
Oct 30, 2025
sydneyrenee
approved these changes
Oct 30, 2025
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Analyzed recent PRs (#555 Adam, #556 Lion) to identify missing core operations blocking optimizer implementations. All missing operations already have open issues.
Analysis Results
Missing Operations from PR #555 (Adam Optimizer - Merged)
subtract(Implement mlx.core.subtract() #264),divide(Implement mlx.core.divide() #4),square(Implement mlx.core.square() #12),sqrt(Implement mlx.core.sqrt() #23),rsqrt(Implement mlx.core.rsqrt() #24),power(Implement mlx.core.power() #8)PR #556 (Lion Optimizer - Closed, Not Merged)
subtractandsignSummary
All 7 missing operations have open issues. No new issues required. PR #556 provides ready implementations for
subtractandsign.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.