feat(gwf): add ghbg package #2247
Conversation
mjreno
force-pushed
the
gwb_array
branch
3 times, most recently
from
fc10d2a to
21826ce
Compare
mjreno
force-pushed
the
gwb_array
branch
2 times, most recently
from
dd4351e to
2b1ac9b
Compare
There was a problem hiding this comment.
Looks good to me, @mjreno. I have a few comments in there, but nothing major. Once you are satisfied, I think it can go in. Maybe leave as dev option for now?
| reader urword | ||
| optional false | ||
| longname maximum number of general-head boundaries in any stress period | ||
| description REPLACE maxbound {'{#1}': 'general-head boundary'} |
There was a problem hiding this comment.
Does this need to be equal to the number of user nodes?
There was a problem hiding this comment.
@christianlangevin no it's max number (across all periods) of grid values not equal to DNODATA.
There was a problem hiding this comment.
Hmm. That seems somewhat inconvenient for the user. If it's considered "grid" data, then maybe the user shouldn't have to enter a size?
There was a problem hiding this comment.
This was an adjustment after the review that minimizes both the memory footprint of the package and changes to existing package code. This will be cumulative as other packages are updated. If you think it sets a bad precedent though we should talk more before I update DRN.
Add grid array input package for General-Head Boundary (GHBG):
- Dependent on modflowpy/flopy#2471, tests will be added after PR is merged
- Distinct from
EVTAandRCHAas input is fully gridded with no layer index array- Model package block should specifically list
GHB6package type and use theREADARRAYGRIDoption-
MAXBOUNDdimension added to restrict allocated size of nodelist- Generic NetCDF read / write capability for layer and grid based package input
- NetCDF dynamic input for layer (
RCHA, EVTA) and grid (GHBG) array input packages stored as timeseries- The current thought is to release
GHBG,WELG,DRNG,RIVG, andCHDGtogether soGHBGwill be marked as a dev feature and doc updates will be withheld for now.- This PR also sets up generic array layer based input as an option for above packages, e.g.
GHBL(orGHBA) could readily be supported and would followEVTAandRCHApatterns.ruffon new and modified python scripts in .doc, autotests, doc, distribution, pymake, and utils subdirectories.fprettifyFor additional information see instructions for contributing and instructions for developing.