Save Position Bug#1
Open
Road-block wants to merge 1 commit into
Open
Conversation
…frame scale Changed UIParent anchoring to default TOPLEFT whudold not updated Might need to nuke saved variables if options frame starts offscreen
Owner
|
Thanks for your effort. I will review the bug and your changes most likely next week. Regards |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Way to reproduce the position bug for upstream version:
Frame will have moved from its apparent saved position.
I was lazy and didn't try to preserve the CENTER anchor logic and fix the screen coord math, instead:
Repeat steps above for this version, frames will save and load position properly regardless of UIScale + scale settings.
Hope it's of some use