Initial OpenACC port of mpas_atm_update_bdy_tend #1301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdicker1
reviewed
May 8, 2025
mgduda
requested changes
May 8, 2025
|
Thanks for the review! I'll address the comments, but just wanted to note that this PR may not be a priority for merging to |
abishekg7
force-pushed
the
atmosphere/port_mpas_atm_update_bdy_tend
branch
from
8bc1e96 to
057ee7e
Compare
|
Addressed the review comments. I did have to rebase with the latest |
mgduda
reviewed
May 16, 2025
mgduda
reviewed
May 16, 2025
mgduda
approved these changes
May 19, 2025
This commit enables the GPU execution of the mpas_atm_update_bdy_tend routine using OpenACC directives for data movement and loops. A new timer has been added to time the host-device data transfers in this subroutine, with the label 'mpas_atm_update_bdy_tend [ACC_data_xfer]' This commit also introduces some integers for loop bounds, so as to dereference scalar integer pointers which the OpenACC parallel regions do not correctly copy to device memory.
abishekg7
force-pushed
the
atmosphere/port_mpas_atm_update_bdy_tend
branch
from
dfaee24 to
fe2e528
Compare
Done. And thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial OpenACC port of
mpas_atm_update_bdy_tend.This port is required to keep
stateandtendvariables from LBCs eventually resident on GPUs.