Add code to plot ocean TF within transect #600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trhille
requested changes
Jan 24, 2025
| if options.interp_temp and (len(times) > 1): | ||
| print('Cannot plot temperature for more than one time index.' + | ||
| ' Skipping temperature interpolation and plotting.') | ||
| options.interp_temp = False | ||
|
|
||
| if options.interp_thermal_forcing and (len(times) > 1): |
There was a problem hiding this comment.
Combine this with if-statement used for temperature above.
trhille
requested changes
Feb 3, 2025
| thickAx.fill_between(distance, upper_surf_nan, lower_surf_nan, color='xkcd:ice blue') | ||
| thickAx.fill_between(distance, bed_transect, thickAx.get_ylim()[0], color='xkcd:greyish brown') | ||
| thickAx.grid(False) | ||
| thickAx.set_ylim([None, 750]) |
There was a problem hiding this comment.
The axis limits should not be hard-coded.
Comment on lines
+248
to
+249
| thickAx.fill_between(distance, upper_surf_nan, lower_surf_nan, color='xkcd:ice blue') | ||
| thickAx.fill_between(distance, bed_transect, thickAx.get_ylim()[0], color='xkcd:greyish brown') |
There was a problem hiding this comment.
These should be applied generally, not just for the thermal forcing case. However, the ice color will need to be skipped if options.temperature.
| y = np.array([float(i) for i in options.y_coords.split(',')]) | ||
|
|
||
| # Determine bounding box using max and min of user-provided coordinates | ||
| pad = 5000 |
There was a problem hiding this comment.
We might want to make the padding size a function of dcEdge. @matthewhoffman , what do you think?
Co-authored-by: Trevor Hillebrand <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the existing
plot_transect.pyscript to add the option of plotting ocean thermal forcing along an ice-shelf transect.The code plots the extrapolated
TFoceanfield for a single time index along a user defined transect. Invalid (1.0e36) TF values are set tonp.nanbefore interpolation happens for each ocean layer. Ice and bedrock are filled in with solid colors if--thermal_forcingoption is set.