-
Notifications
You must be signed in to change notification settings - Fork 40
Remove landIceDraft as a forcing variable from ISOMIP+ #896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
cbegeman
wants to merge
30
commits into
MPAS-Dev:main
Choose a base branch
from
cbegeman:ocn-remove-land-ice-draft-forcing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Remove landIceDraft as a forcing variable from ISOMIP+ #896
cbegeman
wants to merge
30
commits into
MPAS-Dev:main
from
cbegeman:ocn-remove-land-ice-draft-forcing
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@xylar This and E3SM-Ocean-Discussion/E3SM#125 could be relevant to your port. I think this change was already on your radar but let me know if you have any questions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes changes to ISOMIP+ to remove
landIceDraft
as a forcing variable.Changes may need to be made to other tests; I'll update this summary and title when I do that.
Depends on E3SM-Ocean-Discussion/E3SM#125; commits from E3SM-Ocean-Discussion/E3SM#125 included.
Checklist
api.rst
) has any new or modified class, method and/or functions listedE3SM-Project
submodule has been updated with relevant E3SM changesMALI-Dev
submodule has been updated with relevant MALI changesTesting
in this PR) any testing that was used to verify the changes