Convert SCRIP files to CDF5 format for moab #121
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more efficient than partitioning them as we did previously.
Copilot summary
This pull request refactors the
_build_map
function inpyremap/remapper/build_map.py
to improve compatibility with MOAB by introducing a new method for converting SCRIP files to CDF5 format and removing the partitioning logic. The most important changes include the addition of a_convert_to_cdf5
function and the removal of the_moab_partition_scrip_file
function.Changes to improve MOAB compatibility:
_moab_partition_scrip_file
with_convert_to_cdf5
, which converts SCRIP files to the CDF5 format required for MOAB compatibility. This simplifies the workflow by removing partitioning logic and using thencks
tool for file conversion. ([pyremap/remapper/build_map.pyL96-R113](https://github.com/MPAS-Dev/pyremap/pull/121/files#diff-129a160e000bfecfdac3efea475ddcf99d3251f6f295871c3c0cc08f3c5bcdf6L96-R113)
)_build_map
to check the format of source and destination descriptors and invoke_convert_to_cdf5
when the format is notNETCDF3_64BIT_DATA
. This ensures compatibility with MOAB while maintaining flexibility for other formats. ([pyremap/remapper/build_map.pyL61-R71](https://github.com/MPAS-Dev/pyremap/pull/121/files#diff-129a160e000bfecfdac3efea475ddcf99d3251f6f295871c3c0cc08f3c5bcdf6L61-R71)
)