Fix bug in detection of duplicates in user-specified strides#3259
Merged
jdtournier merged 1 commit intomasterfrom Jan 22, 2026
Merged
Fix bug in detection of duplicates in user-specified strides#3259jdtournier merged 1 commit intomasterfrom
jdtournier merged 1 commit intomasterfrom
Conversation
jdtournier
approved these changes
Jan 22, 2026
Member
jdtournier
left a comment
jdtournier
left a comment
There was a problem hiding this comment.
Yup, well spotted. That one's on me...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently making an attempt at refactoring the stride handling as per discussion in #3108 and came across this howler. Quite possibly never actually affected anybody given it will pretty much always be the case that all three spatial strides are either zero or non-zero.