Skip to content

Add map Biospheres #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Add map Biospheres #380

wants to merge 15 commits into from

Conversation

KadaxCTF
Copy link

No description provided.

@a-blob a-blob added New map New map submission Review required 🔍 labels Feb 15, 2025
@a-blob
Copy link
Contributor

a-blob commented Feb 15, 2025

The .conf file is missing. Also, the screenshot ratio seems incorrect.

@AnonomousAccount
Copy link
Contributor

Continuation of #310 ?

@a-blob
Copy link
Contributor

a-blob commented Feb 15, 2025

Screenshot still needs to be in 3:2 ratio (screenshot 600x400px is suggested). You can just delete the screenshot from GitHub, crop it with tools such as https://imagy.app/image-aspect-ratio-changer/, and re-upload the cropped version.

@KadaxCTF
Copy link
Author

KadaxCTF commented Feb 15, 2025 via email

@KadaxCTF
Copy link
Author

KadaxCTF commented Feb 15, 2025 via email

@KadaxCTF
Copy link
Author

Ok I think I got the screenshot to the 3:2 ratio.

@KadaxCTF
Copy link
Author

Is this good or is there anything else I need to change/fix?

@SaiPanneerselvam
Copy link

So again, the map.conf file is missing, making your map unplayable. The error:
image
shows that.

@SaiPanneerselvam
Copy link

SaiPanneerselvam commented Feb 16, 2025

After applying a monkeypatch of sorts, it looks like there is only one good-looking team base, and the others are practically invisible. (please correct me if i am wrong)
image
image
And there also is a random stone wall-like thing over in one of the biospheres

@KadaxCTF
Copy link
Author

Ok I'll try to fix the conf idk why it's not working now and idk how the heck that random walk got in there.

@KadaxCTF
Copy link
Author

OK I think I fixed the problems although when I played it I couldn't change my class does anybody know why that is?

@SaiPanneerselvam
Copy link

  1. Biospheres is spelled as BioSperes LOL. Probably you should fix that.
  2. The hint isnt useful, remember that its optional.
  3. It's extremely hard to know which is a base and which is just a biome, only team red's base is actually visible.
  4. Why is there a second map right below the normal one that is separated by ctf:ignores? (its not really a problem, just a question)

Overall, it looks like you rushed the creation of your map.conf. Otherwise, you seem all good.

@KadaxCTF
Copy link
Author

Sheesh everytime I touch it I screw something else up

@KadaxCTF
Copy link
Author

Also I like the bases how they are I don't think I'll change them.

@a-blob
Copy link
Contributor

a-blob commented Feb 17, 2025

@SaiPanneerselvam

Why is there a second map right below the normal one that is separated by ctf:ignores? (its not really a problem, just a question)

Load the map in a new world every time and that shouldn't happen, unless the map export actually included another map.

@KadaxCTF
Copy link
Author

It does'nt have a second map under it when I load it so idk

@a-blob
Copy link
Contributor

a-blob commented Feb 17, 2025

Then it probably isn't your problem. When testing maps, if you load maps into an old world it might get placed over an already placed map. Also screenshot ratio seems wrong again as it seems like now it's back to the original un-cropped version?

@KadaxCTF
Copy link
Author

Whoops once again I touched it and screwed something up lol

@SaiPanneerselvam
Copy link

Seems like it needs to be named differently
image

@a-blob
Copy link
Contributor

a-blob commented Feb 17, 2025

Seems like it needs to be named differently
image

The screenshot is named screenshot.png so that's correct. Running the setup_maps.sh script in the scripts folder of the game should fix your error.

@SaiPanneerselvam
Copy link

I am away from my computer right now, I will check when I am back.

@SaiPanneerselvam
Copy link

You are correct, that seemed to do just the thing. Thank!

@SaiPanneerselvam
Copy link

So, Is this ready to be pushed/merged with the main?

@KadaxCTF
Copy link
Author

Is it all good then?

@a-blob
Copy link
Contributor

a-blob commented Feb 24, 2025

PR seems good, would be better if the screenshot shows more parts of the map since now a lot of it is cropped out.

@KadaxCTF
Copy link
Author

KadaxCTF commented Feb 24, 2025 via email

@KadaxCTF
Copy link
Author

ok that should do it

@a-blob
Copy link
Contributor

a-blob commented Feb 26, 2025

Overall interesting maps, seems fun and well-built.
Here are a few problems I've noticed:

  • Team zones seem to be set wrong on a few teams. On purple during build time, if you go to the middle of the map inside the middle sphere, you get teleported back for crossing the build-time barrier. On red, if you go behind and next to the glass wall of the map, you get teleported back too.

Even standing on the edge of the team-zone will teleport the player back to base, so make sure to include the barriers within your team-zone too, or players will get teleported back to base if they touch the barriers during build-time

  • In my opinion, blue seems to be over-defended with what's basically a prebuilt base, while green seems under-defended with a ruin around it that barely covers anything and requires more work to patch it up compared to others teams. Might be a bit unfair.
  • Each team seems to have around the same amount of ores, but some are a bit off; might need some readjusting:
    purple d:16 m:20 i:22 c:12
    green: d:14 m:20 i:17 c:14
    red: d:16 m:20 i:38 c:15
    blue: d:15 m:20 i:35 c:12

A few suggestions about the map:

  • Since the middle water sphere is unbreakable with only a door for each team, it might be a bit hard to capture? Depends, but players might just block off the whole entrance with team doors and blocks, making it very hard to enter (and bridging around the sphere seems hard too). So maybe make the entrance a bit bigger.
  • Since the middle sphere has water, it would be nice to add some sand and kelp at the bottom to complete the "biospheres" theme (basically make it kind of oceanfloor-ish).

@KadaxCTF
Copy link
Author

KadaxCTF commented Feb 28, 2025 via email

@KadaxCTF
Copy link
Author

Ok, I fixed the ores and I think the team borders. Also, I added sand and kelp to the middle biosphere and weakened the blue base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants