Skip to content

Rename Divisor package to WeilDivisors #3803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: development
Choose a base branch
from

Conversation

mahrud
Copy link
Member

@mahrud mahrud commented May 11, 2025

With permission from the authors, I renamed the Divisor package to WeilDivisors to prevent the conflict caused by #3543. I also added a warning so that anyone using the old name sees this warning:

i1 : needsPackage "Divisor"
 -- warning: the 'Divisor' package has been renamed as 'WeilDivisors'.

o1 = WeilDivisors

o1 : Package

Later, we can change this to be an error.

  • renamed 'Divisor' package as 'WeilDivisors'
  • added deprecation warning for renamed packages
  • fixed a dead link in ExteriorIdeals

(Karl: feel free to review only the changes in your packages -- I've asked Doug to review the changes in Core)

@mahrud mahrud requested review from kschwede and d-torrance May 11, 2025 19:23
@d-torrance
Copy link
Member

It would be good if this worked with needsPackage too. Right now, we get the following, which I didn't expect:

i1 : needsPackage "Divisor"
 -- warning: the 'Divisor' package has been renamed as 'WeilDivisors'.

o1 = WeilDivisors

o1 : Package

i2 : needsPackage "Divisor"
 -- warning: the 'Divisor' package has been renamed as 'WeilDivisors'.
../../packages/WeilDivisors.m2:3:10:(3):[11]: error: package WeilDivisors not reloaded; try Reload => true

@mahrud
Copy link
Member Author

mahrud commented May 12, 2025

The fix is very minimal, so I pushed a commit with [skip ci].

Copy link
Member

@d-torrance d-torrance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Core changes look good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants