test: cover post-report finalization fallback - #53
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Joshua L. Davis Sr. <Mad-Labs42@users.noreply.github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Pull Request Template
Summary
Adds a focused runner hardening regression test for the post-report finalization fallback path.
Why
Risky behavior now covered: when the primary campaign report has already been generated successfully, a later finalization failure while summarizing/persisting artifact bundle status must not be reported as a primary report failure. The test verifies the final read model remains partial-but-success-style, keeps
report_generation_ok=True, and persistsreport_status='partial'with the finalization error.These tests materially reduce regression risk because this branch controls final review truth and process exit semantics for completed measurement runs; a false report failure would mislead operators and could incorrectly block next-step review flows.
Scope
Test files added/updated:
test_runner_campaign_outcome_hardening.pyRisk
Test-only change. It exercises runner finalization behavior with existing fixtures and does not change production code.
Validation
.\.venv\Scripts\python.exe .agent\scripts\helpers\verify_dev_contract.py --quickor CI equivalent)Commands run:
.venv/bin/python -m ruff check test_runner_campaign_outcome_hardening.pyQUANTMAP_LAB_ROOT=/tmp/quantmap-test-lab .venv/bin/python -m pytest test_runner_campaign_outcome_hardening.py::test_runner_post_report_finalization_failure_preserves_primary_report_truth -qQUANTMAP_LAB_ROOT=/tmp/quantmap-test-lab .venv/bin/python -m pytest test_runner_campaign_outcome_hardening.py -qNote: an initial pytest attempt without
QUANTMAP_LAB_ROOTfailed during import with the repo's expected environment-contract error; reruns with an isolated temp lab root passed.Agent Surface
.agent/scripts/agent_surface_audit.pyis present in this branch, agent surface audit passedNotes
No production behavior changed.