fix(minimax): mm@/mmax@ baseUrl minimax.io → minimaxi.com#122
Open
dev-seahouse wants to merge 1 commit into
Open
fix(minimax): mm@/mmax@ baseUrl minimax.io → minimaxi.com#122dev-seahouse wants to merge 1 commit into
dev-seahouse wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #121
Summary
baseUrlfor theminimaxprovider (mm@,mmax@) fromhttps://api.minimax.iotohttps://api.minimaxi.comminimax.iois the endpoint formmc@(MiniMax Coding Plan) only —mm@/mmax@should always route tominimaxi.comprovider-definitions.ts,config-command.ts,README.md,docs/settings-reference.md, and affected testsRoot cause
BUILTIN_PROVIDERSinprovider-definitions.tshad the wrongbaseUrlfor theminimaxentry. Theminimax-codingentry correctly usedminimax.io, butminimax(the general provider) was pointing there too instead ofminimaxi.com. This causedmm@andmmax@requests to hit the coding endpoint and get 401s.Diff
Behavior change
mm@,mmax@https://api.minimax.io(wrong)https://api.minimaxi.com(correct)mmc@https://api.minimax.iohttps://api.minimax.io(unchanged)Test plan
bun test packages/cli/src/providers/provider-definitions.test.ts— new tests assertminimax→minimaxi.comandminimax-coding→minimax.iobun test packages/cli/src/providers/transport/anthropic-compat.test.ts— updated fixture baseUrl passesbun test— exits 0 (no regressions)claudish --model mm@minimax-m2.7-highspeed --probeconfirms transport usesminimaxi.com