add units for EnergyDensity, VolumetricHeatCapacity, ThermalConductance#75
Open
Selene29 wants to merge 3 commits intoMadsKirkFoged:masterfrom
Open
add units for EnergyDensity, VolumetricHeatCapacity, ThermalConductance#75Selene29 wants to merge 3 commits intoMadsKirkFoged:masterfrom
Selene29 wants to merge 3 commits intoMadsKirkFoged:masterfrom
Conversation
New combined unit: Energy / Volume (J/m³) Adapted to upstream format with UnitDimension attribute, Fraction constructor, Parse method, and updated GetStandardSymbol signature.
New combined unit: Energy / (Volume * Temperature) = J/(m³·K) Adapted to upstream format with UnitDimension attribute, Fraction constructor, Parse method, and updated GetStandardSymbol signature.
New combined unit: Power / Temperature (W/K) Adapted to upstream format with UnitDimension attribute, Fraction constructor, Parse method, and updated GetStandardSymbol signature. Updated ThermalResistance test count to reflect new comparable unit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had them sitting on a 4 month old branch and let claude port them to the current master.
(Recreated from #74 to use a dedicated branch instead of fork's master.)