Feat/Refactor: 유저 이름 변경 기능 추가 및 리팩토링 #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fivedasol
commented
Feb 22, 2025
makourse/account/urls.py
Outdated
| path('logout/', LogoutAPIView.as_view(), name='logout'), # 로그아웃 | ||
| path('profile-image/update', ProfileAPIView.as_view(), name='profile-image-update'), # 프로필 사진 업로드 (post) | ||
| path('profile-image/reset', ProfileAPIView.as_view(), name='profile-image-reset'), # 프로필 기본 이미지로 변경 (patch) | ||
| path('profile/update', ProfileAPIView.as_view(), name='profile-update'), # 프로필 수정 (patch) |
Contributor
Author
There was a problem hiding this comment.
profile에서 이름과 사진을 모두 변경 가능한 api여서 url 이름을 바꿔주었습니다
makourse/account/urls.py
Outdated
| path('profile-image/update', ProfileAPIView.as_view(), name='profile-image-update'), # 프로필 사진 업로드 (post) | ||
| path('profile-image/reset', ProfileAPIView.as_view(), name='profile-image-reset'), # 프로필 기본 이미지로 변경 (patch) | ||
| path('profile/update', ProfileAPIView.as_view(), name='profile-update'), # 프로필 수정 (patch) | ||
| path('profile/image-reset', ProfileAPIView.as_view(), name='profile-image-reset'), # 프로필 기본 이미지로 변경 (post) |
Contributor
Author
There was a problem hiding this comment.
profile이라는걸로 하나 묶고 /image-reset하는게 더 보기 편할거 같아서 변경해주었어요!
Contributor
There was a problem hiding this comment.
이거 그냥 하나의 url로 해도 괜찮지 않나요? POST/ GET/PATCH 사용하는거 같은데.. 뭔가 구분하기 어려울라나?
Contributor
Author
There was a problem hiding this comment.
아 그렇네요.. 어떻게 할까요..? 하나로 해야 swagger에도 여러개로 안나올거 같은데 프론트에서만 잘 구별만 해준다면..
swagger를 보면서 한다면 3개를 하나로 (profile) 묶어도 괜찮을거 같아요
그렇게 수정할까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🚀
Work Description 💚
PR 참고 사항