feat(auth): isolate chat sessions per user with ownership checks - #113
Merged
Conversation
- Add user_session ownership table; first visitor claims a session via INSERT IGNORE. History/debug/clear now verify ownership (non-owner → 404, existence not leaked). Session listing filters by user, and clearAllSessions is admin-only (403 otherwise); admin (role_id=1) bypasses via resolveUserId() returning null. userId is threaded from the servlet thread through chatStream into ToolCallContext so Reactor threads never read ThreadLocal. ADMIN_ROLE_ID is centralized into Constants. Model config switches to deepseek-v4-flash
|
Thank you for your contribution! We will review your request as soon as possible. Please review the code yourself using ponytail https://github.com/DietrichGebert/ponytail. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relate #104
Add user_session ownership table; first visitor claims a session via INSERT IGNORE. History/debug/clear now verify ownership (non-owner → 404, existence not leaked). Session listing filters by user, and clearAllSessions is admin-only (403 otherwise); admin (role_id=1) bypasses via resolveUserId() returning null.
userId is threaded from the servlet thread through chatStream into ToolCallContext so Reactor threads never read ThreadLocal. ADMIN_ROLE_ID is centralized into Constants. Model config switches to deepseek-v4-flash