Skip to content

Clarify adopted task removal#115

Merged
Maples7 merged 1 commit into
masterfrom
fix/issue-112-adopted-remove-output
May 14, 2026
Merged

Clarify adopted task removal#115
Maples7 merged 1 commit into
masterfrom
fix/issue-112-adopted-remove-output

Conversation

@Maples7
Copy link
Copy Markdown
Owner

@Maples7 Maples7 commented May 14, 2026

Summary

  • report adopted task cleanup as unregistered <name> so the CLI no longer implies the external worktree/branch were deleted
  • tighten state-less canonical worktree fallback to require vch's agent/<name> branch, preventing unregistered adopted worktrees from reappearing in vch list or being removed as vch-owned tasks
  • document the adopted removal boundary and add regression coverage for canonical-looking adopted worktrees

Tests

  • swift test --filter TaskServiceTests
  • swift test --filter WorkspaceLocator
  • swift test --filter VchCLISmokeTests/testAdoptCurrentEndToEnd
  • swift test --parallel

Closes #112

For adopted worktrees, report unregistering instead of full removal and keep external ownership explicit.

Tighten state-less canonical worktree fallback so external branches are not rediscovered as vch tasks after unregistering.
@Maples7 Maples7 merged commit f62a7c4 into master May 14, 2026
1 check passed
@Maples7 Maples7 deleted the fix/issue-112-adopted-remove-output branch May 14, 2026 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vch remove --force reports success but leaves worktree/branch intact

1 participant