MDBF-1097: Improve ratelimit on BB #807
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am not sure that this is the correct approach. The request_uri reqlimit is useless it would probably block legit users. The binary_remote_addr makes much more sense but it's probably still to agressive.
fauust
added a commit
to fauust/buildbot
that referenced
this pull request
Jul 16, 2025
|
Blocking heavy API calls is the solution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure that this is the correct approach. The request_uri reqlimit is useless it would probably block legit users. The binary_remote_addr makes much more sense but it's probably still to agressive.
How to test:
1/ deploy on DEV
2/ on DEV:
sudo journalctl -f | grep " limiting "3/ visit https://buildbot.dev.mariadb.org/#/builders/110/builds/150 and expand immediately (as fast as possible) the second trigger --> we should be good.
But this ratelimit can be triggered if you open in tabs a sufficient amount of BB pages with lots of js calls. This probably also depend of your Internet connexion.