Skip to content

Conversation

@frste
Copy link

@frste frste commented Dec 5, 2025

Fullfills issue #252: sql statements can be split by using new split_sql_string function

if external_parser:
return self._split_statements_using_external_parser(sql_string)
else:
return self._parse_sql_internally(sql_string.splitlines())
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finding by my side after commit. If general approach is ok, we may shift split to _parse_sql_internally function

@frste frste marked this pull request as draft December 5, 2025 11:02
@amochin
Copy link
Collaborator

amochin commented Dec 7, 2025

Hi @frste many thanks for your contribution!
The PR is almost ready to be merged - so feel free to publish it when you're ready (it's currently a "draft").

I'd need some minor changes and add a couple of tests though.

If possible, could you please allow me to make changes in your PR? There should be a checkbox like "allow edits from maintainers" or something like that.
Alternatively, I can merge it and continue editing on my side, but in this case your authorship of commits would get lost when I finally squash the PR. I would put your name in the commit message anyway though, so GitHub should show you as a contributor.

Please let me know which options works the best for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants