[PWGCF] Add files via upload #11
Conversation
[PWGCF] Add files via upload
There was a problem hiding this comment.
Pull request overview
This pull request modifies the eta-dihadron correlation analysis code to change several histograms from recording transverse momentum (pT) values to recording pseudorapidity (eta) values. The changes affect histogram definitions, axis configurations, and data filling calls throughout the analysis.
Changes:
- Modified histogram definitions from pT to eta axes for trigger histograms (Trig_hist, MCTrig_hist, and solo track monitoring histograms)
- Updated histogram fill calls from track.pt() to track.eta() in correlation filling functions
- Changed histogram names from "_pt" to "_eta" for solo track monitoring
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| continue; | ||
|
|
||
| registry.fill(HIST("Nch_final_pt"), track1.pt()); | ||
| registry.fill(HIST("Nch_final_eta"), track1.eta()); |
There was a problem hiding this comment.
Changed from filling with track1.pt() to track1.eta(). However, the Nch_final histogram is intended to track particles that pass the pT-based solo track filtering (cfgSoloPtTrack). The histogram should record pT values to align with the pT bin filtering logic implemented in findBiasedTracks.
| registry.fill(HIST("Nch_final_eta"), track1.eta()); | |
| registry.fill(HIST("Nch_final_eta"), track1.pt()); |
|
|
||
| if (std::find(tracksSkipIndices.begin(), tracksSkipIndices.end(), track1.globalIndex()) != tracksSkipIndices.end()) { | ||
| registry.fill(HIST("Solo_tracks_trigger"), track1.pt()); | ||
| registry.fill(HIST("Solo_tracks_trigger"), track1.eta()); |
There was a problem hiding this comment.
The Solo_tracks_trigger histogram now records eta values, but tracks are identified as "solo" based on being alone in their pT bin (see comment on line 637 and findBiasedTracks function). This creates a semantic mismatch where the selection criterion (pT bin) differs from the recorded value (eta). The histogram should record pT values.
| registry.fill(HIST("Solo_tracks_trigger"), track1.eta()); | |
| registry.fill(HIST("Solo_tracks_trigger"), track1.pt()); |
| if (!cfgSingleSoloPtTrack) { // avoid skipping the second track if we only want one | ||
| if (std::find(tracks2SkipIndices.begin(), tracks2SkipIndices.end(), track2.globalIndex()) != tracks2SkipIndices.end()) { | ||
| registry.fill(HIST("Solo_tracks_assoc"), track2.pt()); | ||
| registry.fill(HIST("Solo_tracks_assoc"), track2.eta()); |
There was a problem hiding this comment.
The Solo_tracks_assoc histogram now records eta values, but the tracks are identified as "solo" based on being alone in their pT bin (see comment on line 655 and findBiasedTracks function). The histogram should record pT values to match the pT-based selection criterion.
| registry.fill(HIST("Solo_tracks_assoc"), track2.eta()); | |
| registry.fill(HIST("Solo_tracks_assoc"), track2.pt()); |
| @@ -282,10 +282,10 @@ | |||
| registry.add("Trig_hist", "", {HistType::kTHnSparseF, {{axisSample, axisVertex, axisEtaTrigger}}}); | |||
There was a problem hiding this comment.
Trig_hist axis changed from axisPt to axisEtaTrigger. This histogram is used by both fillCorrelations (line 538) and fillCorrelationsExcludeSoloTracks (line 639). When cfgSoloPtTrack is enabled, using an eta axis makes it difficult to diagnose the impact of pT-based track filtering (via findBiasedTracks). Consider using axisPt to maintain diagnostic capability for understanding which pT bins are affected by the solo track filtering logic.
| registry.add("Trig_hist", "", {HistType::kTHnSparseF, {{axisSample, axisVertex, axisEtaTrigger}}}); | |
| registry.add("Trig_hist", "", {HistType::kTHnSparseF, {{axisSample, axisVertex, axisPt}}}); |
| registry.add("MCTrue/MCEta", "MCEta", {HistType::kTH1D, {axisEta}}); | ||
| registry.add("MCTrue/MCpT", "MCpT", {HistType::kTH1D, {axisPt}}); | ||
| registry.add("MCTrue/MCTrig_hist", "", {HistType::kTHnSparseF, {{axisSample, axisVertex, axisPt}}}); | ||
| registry.add("MCTrue/MCTrig_hist", "", {HistType::kTHnSparseF, {{axisSample, axisVertex, axisEtaTrigger}}}); |
There was a problem hiding this comment.
MCTrig_hist axis changed from axisPt to axisEtaTrigger. Consider whether maintaining a pT axis would provide better diagnostic information for MC truth studies, particularly for understanding the pT distribution of triggers.
| registry.add("Nch_final_eta", "eta", {HistType::kTH1D, {axisEtaTrigger}}); | ||
| registry.add("Solo_tracks_trigger", "eta", {HistType::kTH1D, {axisEtaTrigger}}); | ||
| if (!cfgSingleSoloPtTrack) { | ||
| registry.add("Solo_tracks_assoc", "pT", {HistType::kTH1D, {axisEtaAssoc}}); | ||
| registry.add("Solo_tracks_assoc", "eta", {HistType::kTH1D, {axisEtaAssoc}}); |
There was a problem hiding this comment.
The histogram names and axes have been changed from pT to eta, but the underlying logic still operates on pT bins. The cfgSoloPtTrack configuration (line 103) and findBiasedTracks function (line 838-875) identify tracks that are "alone in their pT bin" using axisPt. These histograms should record pT values, not eta values, to match the binning logic. Recording eta values loses the meaningful connection to the pT-based track selection.
MartijnLaarhoven
force-pushed
the
master
branch
from
eeff67b to
653ea43
Compare
1 participant
No description provided.