[PWGCF] Updating the channel mirroring logic and adding an option to fill histograms run by run#24
Merged
MartijnLaarhoven merged 1 commit intomasterfrom Feb 12, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts FT0 channel gain-equalization indexing within the long-range dihadron correlation task, aligning the correction factor lookup with the FT0 channel ID used throughout the histogramming/mirroring logic.
Changes:
- Update FT0 amplitude gain correction to index
cstFT0RelGainbyid(channel ID) instead ofiCh(loop index), for both FT0A and FT0C.
Comments suppressed due to low confidence (2)
PWGCF/TwoParticleCorrelations/Tasks/longRangeDihadronCor.cxx:695
histAmpCorrectPerRun[lastRunNumber]->Fill(...)is executed wheneversystem == SameEvent, even whencfgRunbyRunAmplitudeFT0is false (in that caselastRunNumberstays -1 and the map entry will be missing/null, leading to a crash via operator[] inserting a nullshared_ptr). Guard this fill withcfgRunbyRunAmplitudeFT0and usefind()(nooperator[]) to ensure the histogram exists before callingFill().
if (system == SameEvent) {
registry.fill(HIST("FT0AmpCorrect"), id, ampl);
histAmpCorrectPerRun[lastRunNumber]->Fill(id, ampl);
}
PWGCF/TwoParticleCorrelations/Tasks/longRangeDihadronCor.cxx:707
- Same issue as above:
histAmpCorrectPerRun[lastRunNumber]->Fill(...)can dereference a nullshared_ptrwhen run-by-run histograms are disabled or not created for the run (becauseoperator[]inserts a default/null entry). Please guard withcfgRunbyRunAmplitudeFT0and lookup withfind()before filling.
if (system == SameEvent) {
registry.fill(HIST("FT0AmpCorrect"), id, ampl);
histAmpCorrectPerRun[lastRunNumber]->Fill(id, ampl);
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating the channel mirroring logic and adding an option to fill histograms run by run