make @patch with create_autospec mock coroutines correctly - #74
Merged
Conversation
Martiusweb
force-pushed
the
patch_autospec
branch
from
February 7, 2018 20:34
6d0976e to
8c2b8cb
Compare
Martiusweb
force-pushed
the
patch_autospec
branch
from
February 27, 2018 19:35
43e58fb to
7e010fd
Compare
Martiusweb
force-pushed
the
patch_autospec
branch
from
February 27, 2018 19:39
7e010fd to
5a56453
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to override asynctest.mock.patch to ensure it uses our version of create_autospec, which supports coroutines (fix of #46).
I'm not yet sure everything works as expected so I'll probably review it and add some tests later (for patch.object, patch.dict, etc).