style: fix require-await rule violations

Author: ssimek

eslint.config.mjs

@@ -75,7 +75,6 @@ export default tseslint.config(
             '@typescript-eslint/no-floating-promises': 'off',           // 48 instances
             'no-async-promise-executor': 'off',                         // 25 instances
             '@typescript-eslint/prefer-promise-reject-errors': 'off',   // 19 instances
-            '@typescript-eslint/require-await': 'off',                  // 7 instances
         }
     },
     {

src/backend/disasm.ts

@@ -499,7 +499,7 @@ export class GdbDisassembler {
         const endAddress = range.qEnd;
         const validationAddr = range.verify;
         // To annotate questionable instructions. Too lazy to do on per instruction basis
-        return new Promise<DisassemblyReturn | Error>(async (resolve) => {
+        return new Promise<DisassemblyReturn | Error>((resolve) => {
             let iter = 0;
             const maxTries = Math.ceil((this.maxInstrSize - this.minInstrSize) / this.instrMultiple);
             const doWork = () => {

src/common.ts

@@ -499,7 +499,7 @@ export function createPortName(procNum: number, prefix: string = 'gdbPort'): str
 }
 
 export function getAnyFreePort(preferred: number): Promise<number> {
-    return new Promise(async (resolve, reject) => {
+    return new Promise((resolve, reject) => {
         function findFreePorts() {
             const portFinderOpts = { min: 60000, max: 62000, retrieve: 1, consecutive: false };
             TcpPortScanner.findFreePorts(portFinderOpts, GDBServer.LOCALHOST).then((ports) => {

src/frontend/extension.ts

@@ -243,7 +243,7 @@ export class CortexDebugExtension {
                 {
                     title: 'Cancel'
                 }
-            ).then(async (v) => {
+            ).then((v) => {
                 if (v && (v.title === installExt)) {
                     vscode.commands.executeCommand('workbench.extensions.installExtension', 'mcu-debug.memory-view');
                 }

src/gdb.ts

@@ -698,7 +698,7 @@ export class GDBDebugSession extends LoggingDebugSession {
                     // For now, we unconditionally suppress events because we will recover after we run the post start commands
                     this.disableSendStoppedEvents = true;
                     this.sendDummyStackTrace = !attach && (!!this.args.runToEntryPoint || !this.args.breakAfterReset);
-                    this.miDebugger.connect(commands).then(async () => {
+                    this.miDebugger.connect(commands).then(() => {
                         const mode = attach ? SessionMode.ATTACH : SessionMode.LAUNCH;
                         this.started = true;
                         this.serverController.debuggerLaunchCompleted();
@@ -1056,7 +1056,7 @@ export class GDBDebugSession extends LoggingDebugSession {
         }
 
         return new Promise<boolean>((resolve, reject) => {
-            const doResolve = async () => {
+            const doResolve = () => {
                 if (this.args.noDebug || (shouldContinue && this.isMIStatusStopped())) {
                     if (mode === SessionMode.RESET) {
                         this.sendDummyStackTrace = true;

src/openocd.ts

@@ -416,7 +416,7 @@ export class OpenOCDServerController extends EventEmitter implements GDBServerCo
         if (this.tclSocket) {
             return Promise.resolve();
         }
-        return new Promise<void>(async (resolve, reject) => {
+        return new Promise<void>((resolve, reject) => {
             if (this.tclSocket === undefined) {
                 const tclPortName = createPortName(0, 'tclPort');
                 const tclPortNum = this.ports[tclPortName];

test/suite/tcpportscanner.test.ts

@@ -68,7 +68,7 @@ suite('TcpPortScanner Tests', () => {
 
             // See if the server started on the requested port. We do it two ways in (near) parallel
             // Both should succeed with the same timeout. See above when LISTEN starts
-            TcpPortScanner.waitForPortOpen(port, hostNameOrIp, true, 50, 1000).then(async () => {
+            TcpPortScanner.waitForPortOpen(port, hostNameOrIp, true, 50, 1000).then(() => {
                 if (doLog) { console.log(`1. Success server port ${port} is ready ${timeIt()}`); }
             }, (err) => {
                 if (doLog) { console.log(`1. Timeout: Failed waiting on port ${port} to open ${timeIt()}`, err); }