[persist] Add a HollowBatch::push_run method and convert usages #32955
+71
−113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nightlies are clean: https://buildkite.com/materialize/nightly/builds?branch=bkirwi%3Abatch-push My main concern here was a perf regression, since we're doing more copies of metadata on the write path... but it seems to come out in the wash. |
5 tasks
DAlperin
reviewed
Jul 21, 2025
Comment on lines
+1055
to
+1056
| // This call means that pushing runs one-at-a-time _in debug mode_ is quadratic | ||
| // in the number of runs. If this is too slow even in tests, we can remove the check. |
There was a problem hiding this comment.
I would be surprised if this were a problem
DAlperin
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
https://github.com/MaterializeInc/database-issues/issues/9194, indirectly... it's always been painful having to carefully assemble several vecs with strict relationships between them, and it's even more painful for stuff like incremental compaction that works run by run.