Skip to content

tests: Always use persistent testdrive, other CI speedups #32971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 16, 2025
Merged

tests: Always use persistent testdrive, other CI speedups #32971

merged 4 commits into from
Jul 16, 2025
+269 −122

Conversation

def-
Copy link
Contributor

@def- def- commented Jul 9, 2025

Some tests create hundreds of containers

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@def- def- force-pushed the pr-persistent-testdrive branch 2 times, most recently from 6090f0f to 2f42431 Compare July 15, 2025 12:57
@def- def- requested review from antiguru and aljoscha July 15, 2025 13:05
@def- def- force-pushed the pr-persistent-testdrive branch 4 times, most recently from 99a3a0c to fe83566 Compare July 15, 2025 18:19
@def- def- requested a review from a team as a code owner July 15, 2025 18:28
@def- def- force-pushed the pr-persistent-testdrive branch 2 times, most recently from 5436241 to 90d48c8 Compare July 16, 2025 09:54
def- added 2 commits July 16, 2025 10:42
@def-
tests: Always use persistent testdrive
82ff587 
Some tests create hundreds of containers
@def-
ci: Split clippy and doctests up, move cargo doc tests to nightly
fd2c5f5 
We have exactly 2 doc tests, not worth the effort.
@def- def- force-pushed the pr-persistent-testdrive branch 10 times, most recently from bd22826 to 3d3b10f Compare July 16, 2025 13:01
@def- def- force-pushed the pr-persistent-testdrive branch from 3d3b10f to fd4f369 Compare July 16, 2025 13:14
@def- def- merged commit 7a7f875 into MaterializeInc:main Jul 16, 2025
89 of 91 checks passed
@def- def- deleted the pr-persistent-testdrive branch July 16, 2025 13:27
@def- def- changed the title tests: Always use persistent testdrive tests: Always use persistent testdrive, other CI speedups Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antiguru antiguru antiguru approved these changes

@aljoscha aljoscha Awaiting requested review from aljoscha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@def- @antiguru