[persist] Configurable logging / auditing for filter pushdown #33496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If auditing is set to 100%, disabling this flag will report any filter pushdown errors without any stability or correctness risk. (Since we always use the result of the normal interpretation path.) I considered making this conditional on auditing being at 100%, but I think it's more useful to keep them separate in case we ever have a bug in the audit mechanism itself. However, I've added some clear expectation in the flag description to help ward against misuse.
DAlperin
approved these changes
Sep 3, 2025
Member
DAlperin
left a comment
DAlperin
left a comment
There was a problem hiding this comment.
LGTM. Makes me wonder if we have any mechanisms to make sure dyncfgs move in lockstep with each other? i.e. audit percentage with audit panic?
Contributor
Author
There are - three, I guess:
Since I could imagine a case where I'd want to enable this flag independently, I decided to go with strategy 3 here. But I think all of them are plausible for different situations... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Trying to narrow down the location of a filter-pushdown issue.
Tips for reviewer
These logs would have been pretty hazardous to produce before, but ought to be okay with the new redaction.
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.