Skip to content

Conversation

@teskje
Copy link
Contributor

@teskje teskje commented Oct 6, 2025

This reverts the changes made in #33686. They rely on schema evolution support for builtin item migrations, which currently breaks the upgrade checks. Thus, reverting unblocks the release.

See Slack thread.

Motivation

  • This PR reverts a known-desirable feature.

Tips for reviewer

As an alternative, we can also merge the forward fix, #33771, if we feel comfortable.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

…ics"

This reverts commit df4f15b, reversing
changes made to 56611d3.
@teskje
Copy link
Contributor Author

teskje commented Oct 6, 2025

Nightlies fail on this PR because of https://github.com/MaterializeInc/database-issues/issues/9755. If we decide to merge this, we'll have to somehow add exceptions for the PreflightCheckRollback test.

@teskje teskje closed this Oct 6, 2025
@teskje teskje deleted the revert-heap-metrics branch October 6, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant