Removed call to SeedRandom() in main of physiboss cell lines project #330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drbergman
reviewed
Nov 15, 2024
Collaborator
drbergman
left a comment
drbergman
left a comment
There was a problem hiding this comment.
Makes sense. The create_cell_types(); call on L129 of main.cpp also (potentially) sets the random seed. It depends on if random_seed is a user parameter. If you want to keep that option open for your users, then leave as is. Otherwise, for this project...
- remove L78-83 in the
custom.cpp - remove
random_seedfromuser_parametersin the config - add the following inside the
<options>element of the config (starts at L44)
<random_seed>0</random_seed>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rheiland caught this today, this is the fix !